Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 598011: Changed fuzzer to randomly remove half of the arguments when running... (Closed)

Created:
10 years, 10 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Changed fuzzer to randomly remove half of the arguments when running on functions that takes five or more arguments. Original version runs for a long time when there is 5 arguments in a runtime function (45+ seconds). The fuzzer can be run with all arguments on all functions regardless of the number of arguments by setting RUN_WITH_ALL_ARGUMENT_ENTRIES to true in fuzz-natives.js Committed: http://code.google.com/p/v8/source/detail?r=3819

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M test/mjsunit/fuzz-natives.js View 1 2 chunks +16 lines, -3 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Rico
10 years, 10 months ago (2010-02-09 12:00:06 UTC) #1
Mads Ager (chromium)
10 years, 10 months ago (2010-02-09 12:04:13 UTC) #2
LGTM

http://codereview.chromium.org/598011/diff/1001/1002
File test/mjsunit/fuzz-natives.js (right):

http://codereview.chromium.org/598011/diff/1001/1002#newcode87
test/mjsunit/fuzz-natives.js:87: argPool.splice(rand,1);
nit: add a space after the comma.

Powered by Google App Engine
This is Rietveld 408576698