Misc debugger enhancements and bug fixes....

src/runtime.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 10709 matching lines @@
   return Heap::undefined_value();
 }
 
 
 static MaybeObject* Runtime_IS_VAR(Arguments args) {
   UNREACHABLE();  // implemented as macro in the parser
   return NULL;
 }
 
 
+#ifdef ENABLE_DEBUGGER_SUPPORT

[Søren Thygesen Gjesse, 2011/01/03 08:56:07]

I think there is a long section above guarded with #ifdef
ENABLE_DEBUGGER_SUPPORT/#endif - please move this up there.

[marklam, 2011/01/04 20:12:13]

Done.

+// Sets a v8 flag.
+static MaybeObject* Runtime_SetFlag(Arguments args) {

[Søren Thygesen Gjesse, 2011/01/03 08:56:07]

Please change name to plural.

[marklam, 2011/01/04 20:12:13]

Done.

+  CONVERT_CHECKED(String, arg, args[0]);
+  SmartPointer<char> flags =
+      arg->ToCString(DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL);
+  FlagList::SetFlagsFromString(*flags, strlen(*flags));
+  return Heap::undefined_value();
+}
+
+
+// Performs a GC.
+// Presently, it only does a full GC.
+static MaybeObject* Runtime_DoGC(Arguments args) {

[Søren Thygesen Gjesse, 2011/01/03 08:56:07]

How about CollectGarbage (or just GC) instead of DoGC?

[marklam, 2011/01/04 20:12:13]

Done.

+  Heap::CollectAllGarbage(true);
+  return Heap::undefined_value();
+}
+
+
+// Gets the current heap usage.
+static MaybeObject* Runtime_GetHeapUsage(Arguments args) {
+  int usage = Heap::SizeOfObjects();
+  if (!Smi::IsValid(usage)) {
+    return *Factory::NewNumberFromInt(usage);
+  }
+  return Smi::FromInt(usage);
+}
+#endif  // ENABLE_DEBUGGER_SUPPORT
+
+
 // ----------------------------------------------------------------------------
 // Implementation of Runtime
 
 #define F(name, number_of_args, result_size)                             \
   { Runtime::k##name, Runtime::RUNTIME, #name,   \
     FUNCTION_ADDR(Runtime_##name), number_of_args, result_size },
 
 
 #define I(name, number_of_args, result_size)                             \
   { Runtime::kInline##name, Runtime::INLINE,     \
@@ skipping 56 matching lines @@
   } else {
     // Handle last resort GC and make sure to allow future allocations
     // to grow the heap without causing GCs (if possible).
     Counters::gc_last_resort_from_js.Increment();
     Heap::CollectAllGarbage(false);
   }
 }
 
 
 } }  // namespace v8::internal