Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10588)

Unified Diff: chrome_frame/chrome_frame_delegate.cc

Issue 5978003: Make IPC::Channel::Listener:OnMessageReceived have a return value indicating ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame_delegate.h ('k') | chrome_frame/external_tab.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_frame_delegate.cc
===================================================================
--- chrome_frame/chrome_frame_delegate.cc (revision 70108)
+++ chrome_frame/chrome_frame_delegate.cc (working copy)
@@ -33,13 +33,14 @@
return is_tab_message;
}
-void ChromeFrameDelegateImpl::OnMessageReceived(const IPC::Message& msg) {
+bool ChromeFrameDelegateImpl::OnMessageReceived(const IPC::Message& msg) {
if (!IsValid()) {
DLOG(WARNING) << __FUNCTION__
<< " Msgs received for a NULL automation client instance";
- return;
+ return false;
}
+ bool handled = true;
IPC_BEGIN_MESSAGE_MAP(ChromeFrameDelegateImpl, msg)
IPC_MESSAGE_HANDLER(AutomationMsg_NavigationStateChanged,
OnNavigationStateChanged)
@@ -66,5 +67,8 @@
OnGoToHistoryEntryOffset)
IPC_MESSAGE_HANDLER(AutomationMsg_GetCookiesFromHost, OnGetCookiesFromHost)
IPC_MESSAGE_HANDLER(AutomationMsg_CloseExternalTab, OnCloseTab)
+ IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
+
+ return handled;
}
« no previous file with comments | « chrome_frame/chrome_frame_delegate.h ('k') | chrome_frame/external_tab.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698