Issue 5977013: Aviod double checking IS_STRING when joining arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5977013: Aviod double checking IS_STRING when joining arrays. (Closed)

Created:
9 years, 11 months ago by sandholm

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Aviod double checking IS_STRING when joining arrays.

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/array.js	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
	M	src/v8natives.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/5977013/diff/1/src/array.js File src/array.js (right): http://codereview.chromium.org/5977013/diff/1/src/array.js#newcode70 src/array.js:70: // Optimized for sparse arrays if separator is ...

9 years, 11 months ago (2011-01-07 13:13:43 UTC) #2

sandholm

9 years, 11 months ago (2011-01-07 13:20:01 UTC) #3

http://codereview.chromium.org/5977013/diff/1/src/array.js
File src/array.js (right):

http://codereview.chromium.org/5977013/diff/1/src/array.js#newcode70
src/array.js:70: // Optimized for sparse arrays if separator is ''.
On 2011/01/07 13:13:43, Lasse Reichstein wrote:
> Make a comment saying that convert is only called on non-strings.

Done.

Expand Messages | Collapse Messages

Issue 5977013: Aviod double checking IS_STRING when joining arrays. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages