Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issue 5977007: Expand scope of bookmark manager resources to all component extension resources. (Closed)

Created:
10 years ago by bryeung
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org
Visibility:
Public.

Description

This fixes resource loading for the virtual keyboard. BUG=none TEST=the keyboard no longer 404s in touchui builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70447

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M chrome/browser/extensions/extension_protocols.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/resources/component_extension_resources.grd View 1 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/chrome.gyp View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tools/grit/resource_ids View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bryeung
10 years ago (2010-12-23 22:33:02 UTC) #1
tony
LGTM as is, but would be nice to fix the nit below. http://codereview.chromium.org/5977007/diff/1/chrome/browser/resources/component_extension_resources.grd File chrome/browser/resources/component_extension_resources.grd ...
9 years, 12 months ago (2010-12-26 08:48:01 UTC) #2
bryeung
PTAL I definitely agree with the comment. I think I've addressed the CL to handle ...
9 years, 11 months ago (2011-01-04 19:38:11 UTC) #3
tony
9 years, 11 months ago (2011-01-04 21:04:31 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698