Issue 5976014: Set a fixed scratch register for ARM code generation...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5976014: Set a fixed scratch register for ARM code generation... (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Set a fixed scratch register for ARM code generation r9 is now set as a fixed scratch register for ARM code generation. removed some unneeded allocation of temporary registers and use the scratch register instead. Committed: http://code.google.com/p/v8/source/detail?r=6162

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -61 lines)			Patch
M	src/arm/assembler-arm.h	View		1 chunk	+1 line, -1 line	2 comments	Download
M	src/arm/lithium-arm.h	View		5 chunks	+1 line, -16 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		3 chunks	+1 line, -6 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	20 chunks	+36 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

LGTM http://codereview.chromium.org/5976014/diff/7001/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/5976014/diff/7001/src/arm/assembler-arm.h#newcode135 src/arm/assembler-arm.h:135: const Register r9 = { 9 }; // ...

9 years, 11 months ago (2011-01-04 14:25:28 UTC) #2

Søren Thygesen Gjesse

9 years, 11 months ago (2011-01-04 14:32:40 UTC) #3

http://codereview.chromium.org/5976014/diff/7001/src/arm/assembler-arm.h
File src/arm/assembler-arm.h (right):

http://codereview.chromium.org/5976014/diff/7001/src/arm/assembler-arm.h#newc...
src/arm/assembler-arm.h:135: const Register r9  = {  9 };  // Used as lithium
codegen scratch register.
On 2011/01/04 14:25:28, Karl Klose wrote:
> Perhaps add a STATIC_ASSERT(kNumAllocatableRegisters <= 8) somewhere?

Added an assert to the ToAllocationIndex to assert that only registers r0 - r7
are allocated.

Expand Messages | Collapse Messages