show notification on locale change

chrome/browser/tab_contents/tab_contents.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/auto_reset.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/stats_counters.h"
 #include "base/string16.h"
 #include "base/string_util.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autocomplete_history_manager.h"
 #include "chrome/browser/autofill/autofill_manager.h"
 #include "chrome/browser/blocked_content_container.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/character_encoding.h"
 #include "chrome/browser/child_process_security_policy.h"
+#include "chrome/browser/chromeos/locale_change_guard.h"
 #include "chrome/browser/content_settings/content_settings_details.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/debugger/devtools_manager.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/dom_operation_notification_details.h"
 #include "chrome/browser/dom_ui/dom_ui.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/download/download_manager.h"
 #include "chrome/browser/download/download_request_limiter.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 791 matching lines @@
   RenderWidgetHostView* rwhv = GetRenderWidgetHostView();
   if (rwhv) {
     rwhv->DidBecomeSelected();
 #if defined(OS_MACOSX)
     rwhv->SetActive(true);
 #endif
   }
 
   WebCacheManager::GetInstance()->ObserveActivity(GetRenderProcessHost()->id());
   last_selected_time_ = base::TimeTicks::Now();
+#if defined(OS_CHROMEOS)
+  chromeos::LocaleChangeGuard::Check(this);
+#endif
 }
 
 void TabContents::FadeForInstant(bool animate) {
   RenderWidgetHostView* rwhv = GetRenderWidgetHostView();
   SkColor whitish = SkColorSetARGB(192, 255, 255, 255);
   if (rwhv)
     rwhv->SetVisuallyDeemphasized(&whitish, animate);
 }
 
 void TabContents::CancelInstantFade() {
@@ skipping 1133 matching lines @@
                     DidNavigateAnyFramePostCommit(details, params));
 
   // Let the LanguageState clear its state.
   language_state_.DidNavigate(details);
 }
 
 void TabContents::CloseConstrainedWindows() {
   // Clear out any constrained windows since we are leaving this page entirely.
   // We use indices instead of iterators in case CloseWindow does something
   // that may invalidate an iterator.
-  int size = static_cast<int>(child_windows_.size());
-  for (int i = size - 1; i >= 0; --i) {
+  for (size_t i = child_windows_.size(); i--;) {

[whywhat, 2011/01/12 16:33:16]

I guess I'd run i from 0 to child_windows_.size() and use
child_windows_[child_windows_.size() - 1 - i].

I'd also add "Indices are enumerated in reverse order to keep the current index
always valid." to the comment.

[Denis Lagno, 2011/01/12 20:27:34]

I've changed the loop.
However I fear to add comment about unknown code.

[whywhat, 2011/01/13 10:09:43]

Yet, you don't fear to change the code itself like you know it, right? :)
Maybe revert the change to leave this beast untouched?

     ConstrainedWindow* window = child_windows_[i];
     if (window) {
       window->CloseConstrainedWindow();
       BlockTabContent(false);
     }
   }
 }
 
 void TabContents::UpdateStarredStateForCurrentURL() {
   BookmarkModel* model = profile()->GetBookmarkModel();
@@ skipping 1361 matching lines @@
 }
 
 void TabContents::SwapInRenderViewHost(RenderViewHost* rvh) {
   render_manager_.SwapInRenderViewHost(rvh);
 }
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = view()->CreateViewForWidget(rvh);
   rwh_view->SetSize(view()->GetContainerSize());
 }