show notification on locale change

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 1322 matching lines @@
     }
   }
   */
   return instant_promo_counter_.get();
 #else
   return NULL;
 #endif
 }
 
 #if defined(OS_CHROMEOS)
+void ProfileImpl::ChangeApplicationLocale(
+    const std::string& locale, bool dont_sync) {

[whywhat, 2011/01/11 10:24:14]

Why not use positive name, smth like sync?
Though I don't see how sync is related to what it affects in code. It looks like
preserve_current_locale or use_override or smth like that.

[Denis Lagno, 2011/01/12 15:33:28]

OK.  I switched back to "keep_local".
It was original naming just thought that words "local" and "locale" are not very
nice seen together.

+  if (locale.empty()) {
+    NOTREACHED();
+    return;
+  }
+  // We maintain kApplicationLocale property in both a global storage
+  // and user's profile.  Global property determines locale of login screen,
+  // while user's profile determines his personal locale preference.
+  PrefService* prefs[] = {

[whywhat, 2011/01/11 10:24:14]

I don't think using array is justified but the small loop in the end. Using
descriptive names for storages would be better than using magic indices.

[Denis Lagno, 2011/01/12 15:33:28]

Done.

+      GetPrefs(),
+      g_browser_process->local_state()
+  };
+  if (dont_sync) {
+    prefs[0]->SetString(prefs::kApplicationLocaleOverride, locale);
+  } else {
+    prefs[0]->SetString(prefs::kApplicationLocale, locale);
+    prefs[0]->SetString(prefs::kApplicationLocaleOverride, "");
+  }
+  prefs[0]->SetString(prefs::kApplicationLocaleBackup, locale);
+  prefs[0]->ClearPref(prefs::kApplicationLocaleAccepted);
+  prefs[1]->SetString(prefs::kApplicationLocale, locale);
+  for (size_t i = 0; i < arraysize(prefs); ++i)
+    prefs[i]->SavePersistentPrefs();
+}
+
 chromeos::ProxyConfigServiceImpl*
     ProfileImpl::GetChromeOSProxyConfigServiceImpl() {
   if (!chromeos_proxy_config_service_impl_) {
     chromeos_proxy_config_service_impl_ =
         new chromeos::ProxyConfigServiceImpl();
   }
   return chromeos_proxy_config_service_impl_;
 }
 
 void ProfileImpl::SetupChromeOSEnterpriseExtensionObserver() {
@@ skipping 11 matching lines @@
 }
 
 PrerenderManager* ProfileImpl::GetPrerenderManager() {
   CommandLine* cl = CommandLine::ForCurrentProcess();
   if (!cl->HasSwitch(switches::kEnablePagePrerender))
     return NULL;
   if (!prerender_manager_.get())
     prerender_manager_.reset(new PrerenderManager(this));
   return prerender_manager_.get();
 }