chrome/common/extensions/docs/build/directory.py - Issue 5975005: Adding extra debugging to extension docs build process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/build/directory.py

Issue 5975005: Adding extra debugging to extension docs build process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/common/extensions/docs/build

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/extensions/docs/build/directory.py

diff --git a/chrome/common/extensions/docs/build/directory.py b/chrome/common/extensions/docs/build/directory.py

index f95344fcb099a27b46e54c358f24ac5548d29a5e..04c748fe1baa83f8ce662519df3bf410f52248cd 100644

--- a/chrome/common/extensions/docs/build/directory.py

+++ b/chrome/common/extensions/docs/build/directory.py

@@ -640,6 +640,8 @@ class Sample(dict):

old_zip_file = zipfile.ZipFile(zip_path, 'r')

except IOError, msg:

raise Exception("Could not read zip at %s: %s" % (zip_path, msg))

+ except zipfile.BadZipfile, msg:

+ raise Exception("File at %s is not a zip file: %s" % (zip_path, msg))

try:

info = old_zip_file.getinfo(zip_manifest_path)

« no previous file with comments | « no previous file | no next file » | no next file with comments »