Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 5975002: scripts: Update factory mod diff for boot-complete job. (Closed)

Created:
10 years ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Nick Sanders, DaveMoore
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

scripts: Update factory mod diff for boot-complete job. I'm changing the boot-complete init script to start on login-prompt-visible instead of login-prompt-ready in http://codereview.chromium.org/5868004/. This also adds a missing description and fixes an outdated email address. BUG=chromium-os:10349 TEST=ran mod_image_for_test.sh with --factory and with --factory_install and checked that resulting image contained boot-complete.conf change Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3a13f91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M mod_for_factory_scripts/200patchInitScript View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
Is there additional testing that I need to do here?
10 years ago (2010-12-17 21:30:22 UTC) #1
DaveMoore
10 years ago (2010-12-17 23:33:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698