Issue 5974011: Revert 70277 - Revert 70275 - Revert 70267 - Refactor PipelineImpl to use Com...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5974011: Revert 70277 - Revert 70275 - Revert 70267 - Refactor PipelineImpl to use Com... (Closed)

Created:
9 years, 12 months ago by acolwell GONE FROM CHROMIUM

Modified:
9 years, 6 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, vrk (LEFT CHROMIUM), sjl, Alpha Left Google, ddorwin+watch_chromium.org, acolwell GONE FROM CHROMIUM, annacc, darin-cc_chromium.org, awong, Paweł Hajdan Jr., scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 70277 - Revert 70275 - Revert 70267 - Refactor PipelineImpl to use CompositeFilter to manage Filter state transitions. BUG=54110 TEST=media_unittests CompositeFilterTest.* Review URL: http://codereview.chromium.org/5744002 TBR=acolwell@chromium.org Review URL: http://codereview.chromium.org/6026013 TBR=acolwell@chromium.org TBR=acolwell@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70287

Patch Set 1 #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -1709 lines)			Patch
M	chrome/browser/media_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	media/base/composite_filter.h	View	1 chunk	+0 lines, -165 lines	0 comments	Download
D	media/base/composite_filter.cc	View	1 chunk	+0 lines, -603 lines	0 comments	Download
D	media/base/composite_filter_unittest.cc	View	1 chunk	+0 lines, -809 lines	0 comments	Download
M	media/base/mock_filters.h	View	4 chunks	+5 lines, -41 lines	0 comments	Download
M	media/base/mock_filters.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	media/base/pipeline.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	media/base/pipeline_impl.h	View	4 chunks	+14 lines, -6 lines	0 comments	Download
M	media/base/pipeline_impl.cc	View	19 chunks	+101 lines, -58 lines	0 comments	Download
M	media/media.gyp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	webkit/glue/webmediaplayer_impl.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages