Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: src/shared/ppapi_proxy/browser_ppp_instance.cc

Issue 5974006: Convert srpc definitions from using int64 to using PP_Instance, PP_Module, an... (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/shared/ppapi_proxy/browser_ppp_instance.cc
===================================================================
--- src/shared/ppapi_proxy/browser_ppp_instance.cc (revision 4034)
+++ src/shared/ppapi_proxy/browser_ppp_instance.cc (working copy)
@@ -70,7 +70,7 @@
uint32_t argc,
const char* argn[],
const char* argv[]) {
- DebugPrintf("Browser::PPP_Instance::DidCreate(%"NACL_PRId64")\n", instance);
+ DebugPrintf("Browser::PPP_Instance::DidCreate(%"NACL_PRId32")\n", instance);
nfullagar 2010/12/23 21:37:00 Is PP_Instance 32 bit or is this left over from th
polina 2010/12/23 21:58:30 Same question. I think this is premature.
noelallen_use_chromium 2010/12/23 22:23:23 Whoops, stale edit. Done. On 2010/12/23 21:37:00,
uint32_t argn_size;
scoped_array<char> argn_serial(ArgArraySerialize(argc, argn, &argn_size));
if (argn_serial.get() == NULL) {
@@ -100,7 +100,7 @@
}
void DidDestroy(PP_Instance instance) {
- DebugPrintf("Browser::PPP_Instance::Delete(%"NACL_PRId64")\n", instance);
+ DebugPrintf("Browser::PPP_Instance::Delete(%"NACL_PRId32")\n", instance);
NaClSrpcChannel* channel = LookupBrowserPppForInstance(instance)->channel();
(void) PppInstanceRpcClient::PPP_Instance_DidDestroy(channel, instance);
}
@@ -108,7 +108,7 @@
void DidChangeView(PP_Instance instance,
const PP_Rect* position,
const PP_Rect* clip) {
- DebugPrintf("Browser::PPP_Instance::DidChangeView(%"NACL_PRId64")\n",
+ DebugPrintf("Browser::PPP_Instance::DidChangeView(%"NACL_PRId32")\n",
instance);
NaClSrpcChannel* channel = LookupBrowserPppForInstance(instance)->channel();
int32_t position_array[4];
@@ -132,7 +132,7 @@
}
void DidChangeFocus(PP_Instance instance, PP_Bool has_focus) {
- DebugPrintf("Browser::PPP_Instance::DidChangeFocus(%"NACL_PRId64")\n",
+ DebugPrintf("Browser::PPP_Instance::DidChangeFocus(%"NACL_PRId32")\n",
instance);
NaClSrpcChannel* channel = LookupBrowserPppForInstance(instance)->channel();
// DidChangeFocus() always succeeds, no need to check the SRPC return value.
@@ -141,7 +141,7 @@
}
PP_Bool HandleInputEvent(PP_Instance instance, const PP_InputEvent* event) {
- DebugPrintf("Browser::PPP_Instance::HandleInputEvent(%"NACL_PRId64")\n",
+ DebugPrintf("Browser::PPP_Instance::HandleInputEvent(%"NACL_PRId32")\n",
instance);
NaClSrpcChannel* channel = LookupBrowserPppForInstance(instance)->channel();
int32_t success;
@@ -159,7 +159,7 @@
}
PP_Bool HandleDocumentLoad(PP_Instance instance, PP_Resource url_loader) {
- DebugPrintf("Browser::PPP_Instance::HandleDocumentLoad(%"NACL_PRId64")\n",
+ DebugPrintf("Browser::PPP_Instance::HandleDocumentLoad(%"NACL_PRId32")\n",
instance);
// TODO(sehr): implement HandleDocumentLoad.
UNREFERENCED_PARAMETER(instance);
@@ -168,7 +168,7 @@
}
PP_Var GetInstanceObject(PP_Instance instance) {
- DebugPrintf("Browser::PPP_Instance::GetInstanceObject(%"NACL_PRId64")\n",
+ DebugPrintf("Browser::PPP_Instance::GetInstanceObject(%"NACL_PRId32")\n",
instance);
NaClSrpcChannel* channel = LookupBrowserPppForInstance(instance)->channel();
ObjectCapability capability;

Powered by Google App Engine
This is Rietveld 408576698