The CertVerifierJob destructor should delete canceled requests....

net/base/cert_verifier_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/cert_verifier.h"
 
 #include "base/callback.h"
 #include "base/file_path.h"
 #include "base/stringprintf.h"
 #include "net/base/cert_test_util.h"
@@ skipping 239 matching lines @@
   for (int i = 0; i < 5; ++i) {
     error = verifier.Verify(google_cert, "www2.example.com", 0, &verify_result,
                             &callback, &request_handle);
     ASSERT_EQ(ERR_IO_PENDING, error);
     ASSERT_TRUE(request_handle != NULL);
     error = callback.WaitForResult();
     verifier.ClearCache();
   }
 }
 
+// Tests that a canceled request is not leaked.
+TEST_F(CertVerifierTest, CancelRequestThenQuit) {
+  scoped_ptr<CertVerifier> verifier(new CertVerifier);

[willchan no longer on Chromium, 2011/01/04 21:33:54]

Nit: Does this need to be heap allocated?

+
+  FilePath certs_dir = GetTestCertsDirectory();
+  scoped_refptr<X509Certificate> google_cert(
+      ImportCertFromFile(certs_dir, "google.single.der"));
+  ASSERT_NE(static_cast<X509Certificate*>(NULL), google_cert);
+
+  int error;
+  CertVerifyResult verify_result;
+  TestCompletionCallback callback;
+  CertVerifier::RequestHandle request_handle;
+
+  error = verifier->Verify(google_cert, "www.example.com", 0, &verify_result,
+                           &callback, &request_handle);
+  ASSERT_EQ(ERR_IO_PENDING, error);
+  ASSERT_TRUE(request_handle != NULL);
+  verifier->CancelRequest(request_handle);
+  verifier.reset();
+}
+
 }  // namespace net