Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 5972004: Do not turn source array elements into writable if doing Array.slice. (Closed)

Created:
10 years ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Do not turn source array elements into writable if doing Array.slice. Array.slice doesn't mutate original array, so it's fine with read only data. Plus nuke unnecessary cast. Committed: http://code.google.com/p/v8/source/detail?r=6113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M src/builtins.cc View 2 chunks +29 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Vitaly, may you have a look?
10 years ago (2010-12-22 11:50:38 UTC) #1
Vitaly Repeshko
10 years ago (2010-12-22 15:19:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698