Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 5971009: Remove try/catch so that ctest blocks builds. (Closed)

Created:
9 years, 11 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Remove try/catch so that ctest blocks builds. All blocking reasons for au test harness flakiness have been resolved. Removing try/catch from ctest so that we propagate the correct error code upon exit. Change-Id: Iee1f09ade37ac7a590c2dbf4ebb96985818f1882 BUG=chromium-os:10434 TEST=Ran ctest unittests. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=50744ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M bin/ctest.py View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sosa
9 years, 11 months ago (2011-01-04 19:13:22 UTC) #1
petkov
9 years, 11 months ago (2011-01-04 19:29:09 UTC) #2
great! LGTM

Powered by Google App Engine
This is Rietveld 408576698