Issue 5971008: move base/object_watcher into base/win and add the win namespace. Fixup calle...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5971008: move base/object_watcher into base/win and add the win namespace. Fixup calle... (Closed)

Created:
9 years, 11 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, amit, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

move base/object_watcher into base/win and add the win namespace. Fixup callers. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70360

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -433 lines)			Patch
M	base/base.gyp	View	3 chunks	+1 line, -2 lines	0 comments	Download
M	base/base.gypi	View	3 chunks	+2 lines, -3 lines	0 comments	Download
D	base/object_watcher.h	View	1 chunk	+0 lines, -92 lines	0 comments	Download
D	base/object_watcher.cc	View	1 chunk	+0 lines, -138 lines	0 comments	Download
D	base/object_watcher_unittest.cc	View	1 chunk	+0 lines, -143 lines	0 comments	Download
M	base/waitable_event_watcher.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	base/waitable_event_watcher_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	base/win/object_watcher.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download
A +	base/win/object_watcher.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
A +	base/win/object_watcher_unittest.cc	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/file_path_watcher/file_path_watcher_win.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/first_run/first_run_win.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_loader_win.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/common/process_watcher_win.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/common/service_process_util_win.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_win.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome_frame/test/win_event_receiver.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome_frame/test/win_event_receiver.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/base/listen_socket.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/base/network_change_notifier_win.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	net/proxy/proxy_config_service_win.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/proxy/proxy_config_service_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/socket/tcp_client_socket_win.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/socket/tcp_client_socket_win.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages