Translate: Move label parsing logic into common code.

Translate: Move label parsing logic into common code.

* Add a string16 & Cocoa version of GetStringF().
* Move logic for parsing translate infobar label into translate_infobars_delegates.
* Make views variant of translate infobars use new code.

BUG=34466
TEST=Translate infobars should continue to workon Windows.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39206

[jeremy, 2010-02-11 13:52:16]

Splitting off separable parts from Mac bring-up of the infobar.

[kuan, 2010-02-11 16:55:45]

http://codereview.chromium.org/597042/diff/1/6
File chrome/browser/translate/translate_infobars_delegates.cc (right):

http://codereview.chromium.org/597042/diff/1/6#newcode163
chrome/browser/translate/translate_infobars_delegates.cc:163: bool
*swapped_language_placeholders) {
indents are off.

http://codereview.chromium.org/597042/diff/1/6#newcode174
chrome/browser/translate/translate_infobars_delegates.cc:174: &offsets_tmp);
indents are off.

http://codereview.chromium.org/597042/diff/1/8
File chrome/browser/views/infobars/translate_infobars.cc (right):

http://codereview.chromium.org/597042/diff/1/8#newcode626
chrome/browser/views/infobars/translate_infobars.cc:626:
delegate->GetMessageText(&message_text_utf16, &offsets,
not sure if this would compile, shldn't "delegate->" be "GetDelegate()->"?

[jeremy, 2010-02-14 08:55:21]

All fixed, ready for another look...

[kuan, 2010-02-16 17:23:53]

LGTM.

http://codereview.chromium.org/597042/diff/3001/3008
File chrome/browser/views/infobars/translate_infobars.cc (right):

http://codereview.chromium.org/597042/diff/3001/3008#newcode486
chrome/browser/views/infobars/translate_infobars.cc:486:
options_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT);
i assume this is fixing RTL bug?  if it is, could you merge this cl into 249
branch?
thanks.