build/common.gypi - Issue 597023: linux: turn on -Wextra - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(62)

My Issues | Starred Open | Closed | All

Unified Diff: build/common.gypi

Issue 597023: linux: turn on -Wextra (Closed)

Patch Set: more Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | chrome/common/extensions/extension.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 6442f409ad8ef6d299443b72d96f05fc7f4092cf..a4328bba55fea8700cacf491795a1d13a05e0e72 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -704,8 +704,7 @@

'-pthread',

'-fno-exceptions',

'-Wall',

- # TODO(evan): turn this back on once the v8 change lands.

- #'-Wextra',

+ '-Wextra',

# Don't warn about unused function params. We use those everywhere.

'-Wno-unused-parameter',

# Don't warn about the "struct foo f = {0};" initialization pattern.

« no previous file with comments | « no previous file | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698