Fix DOMUI login gyp issues.

Fix DOMUI login gyp issues.

I'm not sure this is exactly the right fix, but at least it builds everywhere again.

BUG=none
TEST=compiles with all combinations of touchui and chromeos flags

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69992

[rharrison, 2010-12-22 20:08:08]

This should unbreak the build as you said. I think it might be compiling in more
code then it needs, but the guards within the code will make sure that the
correct classes are used.
Specifically I think both the cros and stub versions of AuthenticatorFacade are
included in both chromeos==1 and 0 now when touchui==1. This should be fine for
now. I will correct it when I have to edit the gypi files for my next patch.
Thanks for fixing this.

On 2010/12/22 19:47:09, bryeung wrote:

[sadrul, 2010-12-22 20:10:18]

The patch breaks touchui=1 chromeos=1 build (I am using shared linking, which
may or may not be relevant).

I think
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...
is a better fix. It passed on the chromeos buildbot, and builds OK with
touchui=1

http://codereview.chromium.org/5969007/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/5969007/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:3587: ['include', '^browser/chromeos/dom_ui/login/'],
I don't think this block is necessary? (The login code doesn't get excluded when
chromeos=1 or touchui=1)

[sadrul, 2010-12-22 20:11:46]

On 2010/12/22 20:10:18, sadrul wrote:
> The patch breaks touchui=1 chromeos=1 build (I am using shared linking, which
> may or may not be relevant).
> 

More details: the linking error:

  SOLINK(target) out/Debug/obj.target/chrome/librenderer.so
  COPY out/Debug/lib.target/librenderer.so
  LINK(target) out/Debug/chrome
out/Debug/obj.target/chrome/libbrowser.so: undefined reference to
`chromeos::LoginUI::LoginUI(TabContents*)'
collect2: ld returned 1 exit status

[sadrul, 2010-12-22 20:12:16]

On 2010/12/22 20:11:46, sadrul wrote:
> On 2010/12/22 20:10:18, sadrul wrote:
> > The patch breaks touchui=1 chromeos=1 build (I am using shared linking,
which
> > may or may not be relevant).

Pooh. I meant touchui=1 chromeos=0

[sadrul, 2010-12-22 22:00:09]

LGTM.

http://codereview.chromium.org/6017006/ Takes care of the link issue for me.

[Nikita (slow), 2010-12-22 22:01:58]

LGTM