gcc/gcc/combine.c - Issue 5968010: [gcc] Yet another gen_lowpart code confused by prt_mode != Pmode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcc/gcc/combine.c

Issue 5968010: [gcc] Yet another gen_lowpart code confused by prt_mode != Pmode (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/nacl-toolchain.git@master

Patch Set: ready for code review Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gcc/gcc/combine.c

diff --git a/gcc/gcc/combine.c b/gcc/gcc/combine.c

index 5078f3e4e7566528e0e4cc7de8fa38b80eece1f2..3eb2123dd3ced77621ee79c993aba92b78a467dd 100644

--- a/gcc/gcc/combine.c

+++ b/gcc/gcc/combine.c

@@ -9892,8 +9892,11 @@ gen_lowpart_for_combine (enum machine_mode omode, rtx x)

return x;

/* Return identity if this is a CONST or symbolic reference. */

+ /* HACK?

pasko-google - do not use 2010/12/24 16:13:09 "TODO(eaeltsin)" would be more stylish than "HACK?

+ When ptr_mode != Pmode, we should not return CONST:ptr_mode for Pmode

+ and vice versa as this confuses SUBST. */

if (omode == Pmode

- && (GET_CODE (x) == CONST

+ && ((GET_CODE (x) == CONST && ptr_mode == Pmode)

|| GET_CODE (x) == SYMBOL_REF

|| GET_CODE (x) == LABEL_REF))

return x;

« no previous file with comments | « no previous file | no next file » | no next file with comments »