Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: chrome/browser/background_application_list_model.cc

Issue 5968009: Change extension unload notification to indicate updates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background_application_list_model.cc
===================================================================
--- chrome/browser/background_application_list_model.cc (revision 69996)
+++ chrome/browser/background_application_list_model.cc (working copy)
@@ -153,9 +153,6 @@
NotificationType::EXTENSION_UNLOADED,
Source<Profile>(profile));
registrar_.Add(this,
- NotificationType::EXTENSION_UNLOADED_DISABLED,
- Source<Profile>(profile));
- registrar_.Add(this,
NotificationType::EXTENSIONS_READY,
Source<Profile>(profile));
ExtensionService* service = profile->GetExtensionService();
@@ -261,9 +258,7 @@
OnExtensionLoaded(Details<Extension>(details).ptr());
break;
case NotificationType::EXTENSION_UNLOADED:
- // Handle extension unload uniformly, falling through to next case.
- case NotificationType::EXTENSION_UNLOADED_DISABLED:
- OnExtensionUnloaded(Details<Extension>(details).ptr());
+ OnExtensionUnloaded(Details<UnloadedExtensionInfo>(details)->extension);
break;
default:
NOTREACHED() << "Received unexpected notification";
@@ -283,7 +278,8 @@
Update();
}
-void BackgroundApplicationListModel::OnExtensionUnloaded(Extension* extension) {
+void BackgroundApplicationListModel::OnExtensionUnloaded(
+ const Extension* extension) {
if (!IsBackgroundApp(*extension))
return;
Update();

Powered by Google App Engine
This is Rietveld 408576698