Change extension unload notification to indicate updates....

chrome/common/extensions/extension.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 716 matching lines @@
 struct UninstalledExtensionInfo {
   explicit UninstalledExtensionInfo(const Extension& extension);
   ~UninstalledExtensionInfo();
 
   std::string extension_id;
   std::set<std::string> extension_api_permissions;
   Extension::Type extension_type;
   GURL update_url;
 };
 
+struct UnloadedExtensionInfo {
+  enum Reason {

[Erik does not do reviews, 2010/12/23 17:05:17]

random thought: should we have a separate reason for a disable due to privilege
increase?

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

We already handle this in a sort of unexpected place: in 
ExtensionService::OnExtensionLoaded, we disable the extension and send a
EXTENSION_UPDATE_DISABLED notification. This seems like a potentially larger
refactor, so I've logged crbug.com/67922 to take a look at this separately.

+    DISABLED,   // The extension was disabled.

[Erik does not do reviews, 2010/12/23 17:05:17]

naming nit: it would be nice if you used the same tense for these.  it's weird
that you have three different values with three different tenses.

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

Good point. Changed to: DISABLE, UPDATE, and UNINSTALL

+    UPDATING,   // The extension is being updated to a newer version.

[Erik does not do reviews, 2010/12/23 17:05:17]

Are we going to need to add a subsequent UPDATE_FAILED notification?  I haven't
looked at when we unload due to update to see whether there's a way that can
happen.

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

I think anyone who's interested could listen for EXTENSION_INSTALL_FAILED. 

+    UNINSTALL,  // The extension is being uninstalled.
+  };
+
+  Reason reason;
+
+  // Was the extension already disabled?
+  bool already_disabled;
+
+  // Can be NULL in the case of an already_disabled extension.

[Erik does not do reviews, 2010/12/23 17:05:17]

seems like there should be an extension id field then

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

I was mistaken that the extension can be NULL (there's an early out in
ExtensionService::UnloadExtension to skip sending the notification in that
case). I've updated the comment.  

+  const Extension* extension;
+
+  UnloadedExtensionInfo(const Extension* extension, Reason reason);
+};
+
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_