Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7969)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/reliability/page_load_test.cc

Issue 5968008: Update file version info/memory details/process utils to use string16.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/chrome_version_info.cc ('K') | « chrome/test/in_process_browser_test.cc ('k') | chrome/test/startup/startup_test.cc » ('j') | chrome/test/startup/startup_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/reliability/page_load_test.cc
===================================================================
--- chrome/test/reliability/page_load_test.cc (revision 69950)
+++ chrome/test/reliability/page_load_test.cc (working copy)
@@ -163,7 +163,8 @@
#if defined(OS_WIN)
// Check file version info for chrome dll.
scoped_ptr<FileVersionInfo> file_info;
- file_info.reset(FileVersionInfo::CreateFileVersionInfo(kChromeDll));
+ file_info.reset(
+ FileVersionInfo::CreateFileVersionInfo(FilePath(kChromeDll)));
last_change = WideToASCII(file_info->last_change());
#elif defined(OS_LINUX) || defined(OS_MACOSX)
// TODO(fmeawad): On Mac, the version retrieved here belongs to the test
« chrome/common/chrome_version_info.cc ('K') | « chrome/test/in_process_browser_test.cc ('k') | chrome/test/startup/startup_test.cc » ('j') | chrome/test/startup/startup_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698