Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/memory_details.cc

Issue 5968008: Update file version info/memory details/process utils to use string16.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/process_util_linux.cc ('K') | « chrome/browser/memory_details.h ('k') | chrome/browser/memory_details_linux.cc » ('j') | chrome/common/chrome_version_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/memory_details.cc
===================================================================
--- chrome/browser/memory_details.cc (revision 69950)
+++ chrome/browser/memory_details.cc (working copy)
@@ -88,7 +88,7 @@
continue;
info.type = iter->type();
- info.titles.push_back(iter->name());
+ info.titles.push_back(WideToUTF16Hack(iter->name()));
child_info.push_back(info);
}
@@ -149,9 +149,9 @@
contents = host->delegate()->GetAsTabContents();
if (!contents)
continue;
- std::wstring title = UTF16ToWideHack(contents->GetTitle());
+ string16 title = contents->GetTitle();
if (!title.length())
- title = L"Untitled";
+ title = UTF8ToUTF16("Untitled");
Evan Martin 2010/12/22 23:03:59 Heh, funny this isn't translated.
Avi (use Gerrit) 2010/12/22 23:25:02 :(
process.titles.push_back(title);
// We need to check the pending entry as well as the virtual_url to
« base/process_util_linux.cc ('K') | « chrome/browser/memory_details.h ('k') | chrome/browser/memory_details_linux.cc » ('j') | chrome/common/chrome_version_info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698