Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 5968008: Update file version info/memory details/process utils to use string16.... (Closed)

Created:
10 years ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, cbentzel+watch_chromium.org, amit, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

Update file version info/memory details/process utils to use string16. BUG=23581 TEST=everything still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70071

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -211 lines) Patch
M base/file_version_info.h View 2 chunks +27 lines, -25 lines 0 comments Download
M base/file_version_info_mac.h View 1 chunk +17 lines, -21 lines 0 comments Download
M base/file_version_info_mac.mm View 2 chunks +32 lines, -32 lines 0 comments Download
M base/file_version_info_win.h View 2 chunks +15 lines, -19 lines 0 comments Download
M base/file_version_info_win.cc View 1 chunk +15 lines, -22 lines 0 comments Download
M base/process_util.h View 7 chunks +7 lines, -7 lines 0 comments Download
M base/process_util.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/process_util_linux.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/process_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/breakpad_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/memory_details.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/memory_details_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/memory_details_mac.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/memory_details_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_constants.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_constants.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M chrome/common/chrome_version_info.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/in_process_browser_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/startup/startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/crash_reporting/minidump_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/reliability/page_load_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome_frame/test/util_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/test_server_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_lib_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
BTW, this currently passes trybots on Mac, Lin, CrOS, and is passing Win as I ...
10 years ago (2010-12-22 22:46:13 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/5968008/diff/1/base/file_version_info.h File base/file_version_info.h (right): http://codereview.chromium.org/5968008/diff/1/base/file_version_info.h#newcode25 base/file_version_info.h:25: // this a less-obvious Windows-ism. FYI, this is ...
10 years ago (2010-12-22 23:03:59 UTC) #2
Avi (use Gerrit)
10 years ago (2010-12-22 23:25:02 UTC) #3
http://codereview.chromium.org/5968008/diff/1/base/file_version_info.h
File base/file_version_info.h (right):

http://codereview.chromium.org/5968008/diff/1/base/file_version_info.h#newcode25
base/file_version_info.h:25: // this a less-obvious Windows-ism.
Lemme take that on as my next cleanup task..

http://codereview.chromium.org/5968008/diff/1/base/process_util_linux.cc
File base/process_util_linux.cc (right):

http://codereview.chromium.org/5968008/diff/1/base/process_util_linux.cc#newc...
base/process_util_linux.cc:223: // TODO(port): make this also work for non-ASCII
filenames
On 2010/12/22 23:03:59, Evan Martin wrote:
> You can remove this TODO, since you've fixed it.

Done.

http://codereview.chromium.org/5968008/diff/1/chrome/browser/memory_details.cc
File chrome/browser/memory_details.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/browser/memory_details.c...
chrome/browser/memory_details.cc:154: title = UTF8ToUTF16("Untitled");
On 2010/12/22 23:03:59, Evan Martin wrote:
> Heh, funny this isn't translated.

:(

http://codereview.chromium.org/5968008/diff/1/chrome/common/chrome_version_in...
File chrome/common/chrome_version_info.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/common/chrome_version_in...
chrome/common/chrome_version_info.cc:17: // FileVersionInfo for the current
module.
On 2010/12/22 23:03:59, Evan Martin wrote:
> (this is the point I was referring to about FileVersionInfo)

Ah, I see.

http://codereview.chromium.org/5968008/diff/1/chrome/test/startup/startup_tes...
File chrome/test/startup/startup_test.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/test/startup/startup_tes...
chrome/test/startup/startup_test.cc:138:
chrome::kBrowserProcessExecutablePath));
On 2010/12/22 23:03:59, Evan Martin wrote:
> Maybe fits on one line?

Nope.

Powered by Google App Engine
This is Rietveld 408576698