Update file version info/memory details/process utils to use string16....

Update file version info/memory details/process utils to use string16.

BUG=23581
TEST=everything still works


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70071

[Avi (use Gerrit), 2010-12-22 22:46:13]

BTW, this currently passes trybots on Mac, Lin, CrOS, and is passing Win as I
speak.

[Evan Martin, 2010-12-22 23:03:59]

LGTM

http://codereview.chromium.org/5968008/diff/1/base/file_version_info.h
File base/file_version_info.h (right):

http://codereview.chromium.org/5968008/diff/1/base/file_version_info.h#newcode25
base/file_version_info.h:25: // this a less-obvious Windows-ism.
FYI, this is why I've put off modifying this file.

I recently looked at what it was doing on Linux (which doesn't even have a
concept of per-file version info) and instead refactored the callers -- most of
them just care about the version of Chrome, in which case they use
chrome::VersionInfo.

So it might be better to just remove all the Mac references to this class (there
should only be a couple, and which only need one or two of these fields; they
can be refactored to call the appropriate system API directly) and make this
whole file a Windows-specific class.

http://codereview.chromium.org/5968008/diff/1/base/process_util_linux.cc
File base/process_util_linux.cc (right):

http://codereview.chromium.org/5968008/diff/1/base/process_util_linux.cc#newc...
base/process_util_linux.cc:223: // TODO(port): make this also work for non-ASCII
filenames
You can remove this TODO, since you've fixed it.

http://codereview.chromium.org/5968008/diff/1/chrome/browser/memory_details.cc
File chrome/browser/memory_details.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/browser/memory_details.c...
chrome/browser/memory_details.cc:154: title = UTF8ToUTF16("Untitled");
Heh, funny this isn't translated.

http://codereview.chromium.org/5968008/diff/1/chrome/common/chrome_version_in...
File chrome/common/chrome_version_info.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/common/chrome_version_in...
chrome/common/chrome_version_info.cc:17: // FileVersionInfo for the current
module.
(this is the point I was referring to about FileVersionInfo)

http://codereview.chromium.org/5968008/diff/1/chrome/test/startup/startup_tes...
File chrome/test/startup/startup_test.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/test/startup/startup_tes...
chrome/test/startup/startup_test.cc:138:
chrome::kBrowserProcessExecutablePath));
Maybe fits on one line?

[Avi (use Gerrit), 2010-12-22 23:25:02]

http://codereview.chromium.org/5968008/diff/1/base/file_version_info.h
File base/file_version_info.h (right):

http://codereview.chromium.org/5968008/diff/1/base/file_version_info.h#newcode25
base/file_version_info.h:25: // this a less-obvious Windows-ism.
Lemme take that on as my next cleanup task..

http://codereview.chromium.org/5968008/diff/1/base/process_util_linux.cc
File base/process_util_linux.cc (right):

http://codereview.chromium.org/5968008/diff/1/base/process_util_linux.cc#newc...
base/process_util_linux.cc:223: // TODO(port): make this also work for non-ASCII
filenames
On 2010/12/22 23:03:59, Evan Martin wrote:
> You can remove this TODO, since you've fixed it.

Done.

http://codereview.chromium.org/5968008/diff/1/chrome/browser/memory_details.cc
File chrome/browser/memory_details.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/browser/memory_details.c...
chrome/browser/memory_details.cc:154: title = UTF8ToUTF16("Untitled");
On 2010/12/22 23:03:59, Evan Martin wrote:
> Heh, funny this isn't translated.

:(

http://codereview.chromium.org/5968008/diff/1/chrome/common/chrome_version_in...
File chrome/common/chrome_version_info.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/common/chrome_version_in...
chrome/common/chrome_version_info.cc:17: // FileVersionInfo for the current
module.
On 2010/12/22 23:03:59, Evan Martin wrote:
> (this is the point I was referring to about FileVersionInfo)

Ah, I see.

http://codereview.chromium.org/5968008/diff/1/chrome/test/startup/startup_tes...
File chrome/test/startup/startup_test.cc (right):

http://codereview.chromium.org/5968008/diff/1/chrome/test/startup/startup_tes...
chrome/test/startup/startup_test.cc:138:
chrome::kBrowserProcessExecutablePath));
On 2010/12/22 23:03:59, Evan Martin wrote:
> Maybe fits on one line?

Nope.