Fix Solaris build

Fix Solaris build

[Erik Corry, 2010-12-22 09:52:37]

http://codereview.chromium.org/5968004/diff/3001/src/v8utils.h
File src/v8utils.h (right):

http://codereview.chromium.org/5968004/diff/3001/src/v8utils.h#newcode32
src/v8utils.h:32: #include <stdarg.h>
We don't like to include system headers after our own headers if it can be
avoided.  Can it?

[ry, 2010-12-22 19:36:54]

http://codereview.chromium.org/5968004/diff/3001/src/v8utils.h
File src/v8utils.h (right):

http://codereview.chromium.org/5968004/diff/3001/src/v8utils.h#newcode32
src/v8utils.h:32: #include <stdarg.h>
On 2010/12/22 09:52:37, Erik Corry wrote:
> We don't like to include system headers after our own headers if it can be
> avoided.  Can it?

platform.h has stdarg.h - I included that - is that okay?

[Erik Corry, 2011-01-05 12:23:13]

http://codereview.chromium.org/5968004/diff/5/src/utils.h
File src/utils.h (right):

http://codereview.chromium.org/5968004/diff/5/src/utils.h#newcode757
src/utils.h:757: inline Dest BitCast(Source*& source) {
Why is this needed?

[ry, 2011-01-05 18:34:54]

http://codereview.chromium.org/5968004/diff/5/src/utils.h
File src/utils.h (right):

http://codereview.chromium.org/5968004/diff/5/src/utils.h#newcode757
src/utils.h:757: inline Dest BitCast(Source*& source) {
On 2011/01/05 12:23:13, Erik Corry wrote:
> Why is this needed?

I get many errors like this from GCC 3.4.3. 


src/factory.h: In static member function `static
v8::internal::Handle<v8::internal::Map>
v8::internal::Factory::byte_array_map()':
src/factory.h:344: error: call of overloaded `BitCast(v8::internal::Object**)'
is ambiguous
src/utils.h:746: note: candidates are: Dest v8::internal::BitCast(const Source&)
[with Dest = v8::internal::Map**, Source = v8::internal::Object**]
src/utils.h:757: note:                 Dest v8::internal::BitCast(Source*) [with
Dest = v8::internal::Map**, Source = v8::internal::Object*]


There was a patch for this change before:
http://codereview.chromium.org/3130033/show

[ry, 2011-01-06 19:08:20]

Eric, this could be merged without the BitCast change - it's not really related
to Solaris but rather old GCC. I can try to get that in in a separate patch.

[ry, 2011-01-10 22:14:49]

I removed the BitCast change. Vyacheslav's patch
(https://groups.google.com/d/msg/v8-dev/jOv1yvVfQyk/eKN_4mgArOUJ) fixed that
issue for me.

[Erik Corry, 2011-01-11 11:44:58]

Committed as 6259.  Sorry about the delays on this one.