Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4298)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/tests/browser_uitest.cc

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Changes per Paweł's comments. Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_restore_uitest.cc ('k') | chrome/common/logging_chrome_uitest.cc » ('j') | chrome/test/automation/proxy_launcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tests/browser_uitest.cc
diff --git a/chrome/browser/ui/tests/browser_uitest.cc b/chrome/browser/ui/tests/browser_uitest.cc
index f3cfc7837a27df502720e11e3ec65e2db001f128..680a86a09c8759db6600f2fb705dcebcb212ce46 100644
--- a/chrome/browser/ui/tests/browser_uitest.cc
+++ b/chrome/browser/ui/tests/browser_uitest.cc
@@ -83,7 +83,7 @@ TEST_F(BrowserTest, PosixSessionEnd) {
#ifdef CHROME_V8
TEST_F(BrowserTest, NullOpenerRedirectForksProcess) {
// This test only works in multi-process mode
- if (in_process_renderer())
+ if (ProxyLauncher::in_process_renderer())
return;
net::TestServer test_server(net::TestServer::TYPE_HTTP,
@@ -134,7 +134,7 @@ TEST_F(BrowserTest, NullOpenerRedirectForksProcess) {
// a same-page-redirect) will not fork a new process.
TEST_F(BrowserTest, MAYBE_OtherRedirectsDontForkProcess) {
// This test only works in multi-process mode
- if (in_process_renderer())
+ if (ProxyLauncher::in_process_renderer())
return;
net::TestServer test_server(net::TestServer::TYPE_HTTP,
« no previous file with comments | « chrome/browser/sessions/session_restore_uitest.cc ('k') | chrome/common/logging_chrome_uitest.cc » ('j') | chrome/test/automation/proxy_launcher.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698