chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc - Issue 5967003: Refactor UITestBase/ProxyLauncher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add POD struct to hold some launcher variables. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc

diff --git a/chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc b/chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc

index 550f8d465aae5aa9699d9ed42f23afeb199bf147..fb617a5526e9b82328808be48f5fe73825ff569a 100644

--- a/chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc

+++ b/chrome/test/interactive_ui/fast_shutdown_interactive_uitest.cc

@@ -54,5 +54,6 @@ TEST_F(FastShutdown, MAYBE_SlowTermination) {

ASSERT_TRUE(automation()->WaitForAppModalDialog());

ASSERT_TRUE(automation()->ClickAppModalDialogButton(

MessageBoxFlags::DIALOGBUTTON_OK));

- ASSERT_TRUE(WaitForBrowserProcessToQuit());

+ ASSERT_TRUE(WaitForBrowserProcessToQuit(

+ TestTimeouts::wait_for_terminate_timeout_ms()));

}