chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc - Issue 5967003: Refactor UITestBase/ProxyLauncher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add POD struct to hold some launcher variables. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

diff --git a/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc b/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

index 7732032d9f997a3a028a2ffd870a496782351fe7..2b6c5a627394678c46d4b8172e32809098883143 100644

--- a/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

+++ b/chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc

@@ -202,7 +202,7 @@ TEST_F(ResourceDispatcherTest, CrossSiteOnunloadCookie) {

// strip the app on the build bots, this is bad times.

TEST_F(ResourceDispatcherTest, CrossSiteAfterCrash) {

// This test only works in multi-process mode

- if (in_process_renderer())

+ if (ProxyLauncher::in_process_renderer())

return;

scoped_refptr<BrowserProxy> browser_proxy(automation()->GetBrowserWindow(0));