Refactor UITestBase/ProxyLauncher.

chrome/test/automation/proxy_launcher.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_AUTOMATION_PROXY_LAUNCHER_H_
 #define CHROME_TEST_AUTOMATION_PROXY_LAUNCHER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/command_line.h"
+#include "base/process.h"
+#include "base/scoped_ptr.h"
+#include "base/scoped_temp_dir.h"
+#include "base/time.h"
 
 class AutomationProxy;
-class UITestBase;
-
-// Subclass from this class to use a different implementation of AutomationProxy
-// or to use different channel IDs inside a class that derives from UITest.
+
+// Subclass from this class to use a different AutomationProxy
+// implementation or to override browser launching behavior.
 class ProxyLauncher {

[John Grabowski, 2011/01/07 03:36:11]

All classes need a comment.  Your comment says when to subclass but does not
give a general description.  E.g.
"Base class for doing blah.  Contains functionality for BLAH."

[dtu, 2011/01/08 01:54:57]

Done.

  public:
-  ProxyLauncher() {}
-  virtual ~ProxyLauncher() {}
+  // Profile theme type choices.
+  enum ProfileType {
+    DEFAULT_THEME = 0,
+    COMPLEX_THEME = 1,
+    NATIVE_THEME = 2,
+    CUSTOM_FRAME = 3,
+    CUSTOM_FRAME_NATIVE_THEME = 4,
+  };
+
+  // Different ways to quit the browser.
+  enum ShutdownType {
+    WINDOW_CLOSE,
+    USER_QUIT,
+    SESSION_ENDING,
+  };
+
+  ProxyLauncher();
+
+  virtual ~ProxyLauncher();
 
   // Creates an automation proxy.
   virtual AutomationProxy* CreateAutomationProxy(
       int execution_timeout) = 0;
 
-  // Launches the browser if needed and establishes a connection
-  // connection with it using the specified UITestBase.
-  virtual void InitializeConnection(UITestBase* ui_test_base) const = 0;
+  // Launches the browser if needed and establishes a connection with it.
+  virtual void InitializeConnection(const CommandLine& arguments,

[John Grabowski, 2011/01/07 03:36:11]

That's a lotta args.
Consider adding a POD struct for "params" whose ctor sets some default values. 
That way if you add "just one more" parem you don't need to change 15 sites.

[dtu, 2011/01/08 01:54:57]

Done.

+                                    bool include_testing_id,
+                                    bool clear_profile,
+                                    FilePath& template_user_data,
+                                    ProfileType profile_type,
+                                    FilePath browser_directory,
+                                    bool show_window,
+                                    bool wait_for_initial_loads,
+                                    base::TimeTicks* launch_time) = 0;
 
   // Returns the automation proxy's channel with any prefixes prepended,
   // for passing as a command line parameter over to the browser.
   virtual std::string PrefixedChannelID() const = 0;
 
+  // Launches the browser and IPC testing connection in server mode.
+  void LaunchBrowserAndServer(const CommandLine& arguments,
+                              bool include_testing_id,
+                              bool clear_profile,
+                              FilePath& template_user_data,
+                              ProfileType profile_type,
+                              FilePath browser_directory,
+                              bool show_window,
+                              bool wait_for_initial_loads,
+                              base::TimeTicks* launch_time);
+
+  // Launches the IPC testing connection in client mode,
+  // which then attempts to connect to a browser.
+  void ConnectToRunningBrowser(bool wait_for_initial_loads);
+
+  // Only for pyauto.
+  void set_command_execution_timeout_ms(int timeout);
+
+  // Closes the browser and IPC testing server.
+  void CloseBrowserAndServer(ShutdownType shutdown_type,
+                             base::TimeDelta* quit_time);
+
+  // Launches the browser with the given command line.
+  // TODO(phajdan.jr): Make LaunchBrowser private. Tests should use
+  // LaunchAnotherBrowserBlockUntilClosed.
+  void LaunchBrowser(const CommandLine& arguments,
+                     bool include_testing_id,
+                     bool clear_profile,
+                     FilePath& template_user_data,
+                     ProfileType profile_type,
+                     FilePath browser_directory,
+                     bool show_window,
+                     base::TimeTicks* launch_time);
+
+#if !defined(OS_MACOSX)
+  // This function is deliberately not defined on the Mac because re-using an
+  // existing browser process when launching from the command line isn't a
+  // concept that we support on the Mac; AppleEvents are the Mac solution for

[John Grabowski, 2011/01/07 03:36:11]

Wording is a bit funny here.  AppleEvents don't let you launch another browser
process as such.  Just say "the concept doesn't apply to Mac; you can't have N
browser processes."

[dtu, 2011/01/08 01:54:57]

Done.

+  // the same need. Any test based on this function doesn't apply to the Mac.
+
+  // Launches an another browser process and waits for it to finish. Returns

[John Grabowski, 2011/01/07 03:36:11]

"an another" --> "another"

[dtu, 2011/01/08 01:54:57]

Done.

+  // true on success.
+  bool LaunchAnotherBrowserBlockUntilClosed(const CommandLine& cmdline,
+                                            bool include_testing_id,
+                                            FilePath browser_directory,
+                                            bool show_window,
+                                            base::TimeTicks* launch_time);
+#endif
+
+  // Exits out of browser instance.
+  void QuitBrowser(ShutdownType shutdown_type,
+                   base::TimeDelta* quit_time);
+
+  // Terminates the browser, simulates end of session.
+  void TerminateBrowser(base::TimeDelta* quit_time);
+
+  // Check that no processes related to Chrome exist, displaying
+  // the given message if any do.
+  void AssertAppNotRunning(const std::wstring& error_message);
+
+  // Returns true when the browser process is running, independent if any
+  // renderer process exists or not. It will returns false if an user closed the
+  // window or if the browser process died by itself.
+  bool IsBrowserRunning();
+
+  // Returns true when timeout_ms milliseconds have elapsed.
+  // Returns false if the browser process died while waiting.
+  bool CrashAwareSleep(int timeout_ms);
+
+  // Wait for the browser process to shut down on its own (i.e. as a result of
+  // some action that your test has taken).
+  bool WaitForBrowserProcessToQuit();

[John Grabowski, 2011/01/07 03:36:11]

Suggest adding timeout on any WaitFor-type method, like this one.

[dtu, 2011/01/08 01:54:57]

Done.

+
+  AutomationProxy* automation() const;
+
+  // Return the user data directory being used by the browser instance.
+  FilePath user_data_dir() const;
+
+  // Get the handle of browser process connected to the automation. This
+  // function only returns a reference to the handle so the caller does not
+  // own the handle returned.
+  base::ProcessHandle process() const;
+
+  // Return the process id of the browser process (-1 on error).
+  base::ProcessId process_id() const;
+
+  void set_test_name(const std::string& name) {
+    test_name_ = name;
+  }
+
+  // Get/Set a flag to run the renderer in process when running the tests.

[John Grabowski, 2011/01/07 03:36:11]

in-process

[dtu, 2011/01/08 01:54:57]

Done.

+  static bool in_process_renderer() { return in_process_renderer_; }
+  static void set_in_process_renderer(bool value) {
+    in_process_renderer_ = value;
+  }
+
+  // Get/Set a flag to run the renderer outside the sandbox when running tests.
+  static bool no_sandbox() { return no_sandbox_; }
+  static void set_no_sandbox(bool value) {
+    no_sandbox_ = value;
+  }
+
+  // Get/Set a flag to run with DCHECKs enabled in release.
+  static bool enable_dcheck() { return enable_dcheck_; }
+  static void set_enable_dcheck(bool value) {
+    enable_dcheck_ = value;
+  }
+
+  // Get/Set a flag to dump the process memory without crashing on DCHECKs.
+  static bool silent_dump_on_dcheck() { return silent_dump_on_dcheck_; }
+  static void set_silent_dump_on_dcheck(bool value) {
+    silent_dump_on_dcheck_ = value;
+  }
+
+  // Get/Set a flag to disable breakpad handling.

[John Grabowski, 2011/01/07 03:36:11]

Seems like a number of these could be bits set in a "flags" type field, ored
together.  Might make it easier to add "just one more" flag, and reduce code
size.

+  static bool disable_breakpad() { return disable_breakpad_; }
+  static void set_disable_breakpad(bool value) {
+    disable_breakpad_ = value;
+  }
+
+  // Get/Set a flag to run the plugin processes inside the sandbox when running
+  // the tests
+  static bool safe_plugins() { return safe_plugins_; }
+  static void set_safe_plugins(bool value) {
+    safe_plugins_ = value;
+  }
+
+  static bool show_error_dialogs() { return show_error_dialogs_; }
+  static void set_show_error_dialogs(bool value) {
+    show_error_dialogs_ = value;
+  }
+
+  static bool full_memory_dump() { return full_memory_dump_; }
+  static void set_full_memory_dump(bool value) {
+    full_memory_dump_ = value;
+  }
+
+  static bool dump_histograms_on_exit() { return dump_histograms_on_exit_; }
+  static void set_dump_histograms_on_exit(bool value) {
+    dump_histograms_on_exit_ = value;
+  }
+
+  static const std::string& js_flags() { return js_flags_; }
+  static void set_js_flags(const std::string& value) {
+    js_flags_ = value;
+  }
+
+  static const std::string& log_level() { return log_level_; }
+  static void set_log_level(const std::string& value) {
+    log_level_ = value;
+  }
+
+ protected:
+  virtual bool ShouldFilterInet() {
+    return true;
+  }
+
  private:
+  void WaitForBrowserLaunch(bool wait_for_initial_loads);
+
+  // Prepare command line that will be used to launch the child browser process.
+  void PrepareTestCommandline(CommandLine* command_line,
+                              bool include_testing_id);
+
+  bool LaunchBrowserHelper(const CommandLine& arguments,
+                           bool include_testing_id,
+                           FilePath browser_directory,
+                           bool wait,
+                           bool show_window,
+                           base::TimeTicks* launch_time,
+                           base::ProcessHandle* process);
+
+  // Wait a certain amount of time for all the app processes to exit,
+  // forcibly killing them if they haven't exited by then.
+  // It has the side-effect of killing every browser window opened in your
+  // session, even those unrelated in the test.
+  void CleanupAppProcesses();
+
+  scoped_ptr<AutomationProxy> automation_proxy_;
+
+  // We use a temporary directory for profile to avoid issues with being
+  // unable to delete some files because they're in use, etc.
+  ScopedTempDir temp_profile_dir_;
+
+  // Name of currently running automeated test passed to Chrome process.
+  std::string test_name_;
+
+  // Handle to the first Chrome process.
+  base::ProcessHandle process_;
+
+  // PID of |process_| (for debugging).
+  base::ProcessId process_id_;
+
+  // True if we're in single process mode.
+  static bool in_process_renderer_;
+
+  // If true, runs the renderer outside the sandbox.
+  static bool no_sandbox_;
+
+  // If true, runs plugin processes inside the sandbox.
+  static bool safe_plugins_;
+
+  // If true, write full memory dump during crash.
+  static bool full_memory_dump_;
+
+  // If true, a user is paying attention to the test, so show error dialogs.
+  static bool show_error_dialogs_;
+
+  // Include histograms in log on exit.
+  static bool dump_histograms_on_exit_;
+
+  // Enable dchecks in release mode.
+  static bool enable_dcheck_;
+
+  // Dump process memory on dcheck without crashing.
+  static bool silent_dump_on_dcheck_;
+
+  // Disable breakpad on the browser.
+  static bool disable_breakpad_;
+
+  // Flags passed to the JS engine.
+  static std::string js_flags_;
+
+  // Logging level.
+  static std::string log_level_;
+
   DISALLOW_COPY_AND_ASSIGN(ProxyLauncher);
 };
 
 // Uses an automation proxy that communicates over a named socket.
 // This is used if you want to connect an AutomationProxy
 // to a browser process that is already running.
 // The channel id of the proxy is a constant specified by kInterfacePath.
 class NamedProxyLauncher : public ProxyLauncher {
  public:
   // If launch_browser is true, launches Chrome with named interface enabled.
   // Otherwise, there should be an existing instance the proxy can connect to.
   NamedProxyLauncher(bool launch_browser, bool disconnect_on_failure);
 
   virtual AutomationProxy* CreateAutomationProxy(int execution_timeout);
-  virtual void InitializeConnection(UITestBase* ui_test_base) const;
+  virtual void InitializeConnection(const CommandLine& arguments,
+                                    bool include_testing_id,
+                                    bool clear_profile,
+                                    FilePath& template_user_data,
+                                    ProfileType profile_type,
+                                    FilePath browser_directory,
+                                    bool show_window,
+                                    bool wait_for_initial_loads,
+                                    base::TimeTicks* launch_time);
   virtual std::string PrefixedChannelID() const;
 
  protected:
   std::string channel_id_;      // Channel id of automation proxy.
   bool launch_browser_;         // True if we should launch the browser too.
   bool disconnect_on_failure_;  // True if we disconnect on IPC channel failure.
 
  private:
   DISALLOW_COPY_AND_ASSIGN(NamedProxyLauncher);
 };
 
 // Uses an automation proxy that communicates over an anonymous socket.
 class AnonymousProxyLauncher : public ProxyLauncher {
  public:
   explicit AnonymousProxyLauncher(bool disconnect_on_failure);
   virtual AutomationProxy* CreateAutomationProxy(int execution_timeout);
-  virtual void InitializeConnection(UITestBase* ui_test_base) const;
+  virtual void InitializeConnection(const CommandLine& arguments,
+                                    bool include_testing_id,
+                                    bool clear_profile,
+                                    FilePath& template_user_data,
+                                    ProfileType profile_type,
+                                    FilePath browser_directory,
+                                    bool show_window,
+                                    bool wait_for_initial_loads,
+                                    base::TimeTicks* launch_time);
   virtual std::string PrefixedChannelID() const;
 
  protected:
   std::string channel_id_;      // Channel id of automation proxy.
   bool disconnect_on_failure_;  // True if we disconnect on IPC channel failure.
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AnonymousProxyLauncher);
 };
 
 #endif  // CHROME_TEST_AUTOMATION_PROXY_LAUNCHER_H_
-