Show hand cursor only on small user pods and labels

Show hand cursor only on small user pods and labels

BUG=chromium-os:9296
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71049

[Dmitry Polukhin, 2010-12-27 08:25:06]

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/user_view.h (right):

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/user_view.h:43: virtual bool is_user_selected()
const = 0;
I would recommend to rename this function to IsUserSelected because some
derivatives classes may do non-trivial work to check selection status.

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/username_view.cc (right):

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/username_view.cc:36:
C::set_use_small_shape(use_small_shape);
I would prefer passing this in constructor as argument in stead of using setter.

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/username_view.h (right):

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/username_view.h:41: bool get_use_small_shape()
const { return use_small_shape_; }
Getter shoudn't have get in its name. Comment about the functions would be nice.

[glotov, 2010-12-30 15:54:52]

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/user_view.h (right):

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/user_view.h:43: virtual bool is_user_selected()
const = 0;
OK. However, on the other hand, leaving it this way would make developers do
only simple things there, witch should be expected.

On 2010/12/27 08:25:06, Dmitry Polukhin wrote:
> I would recommend to rename this function to IsUserSelected because some
> derivatives classes may do non-trivial work to check selection status.

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/username_view.cc (right):

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/username_view.cc:36:
C::set_use_small_shape(use_small_shape);
I would prefer this too, but to do that I need to modify RoundedView<> template
class ctor. And it may be used not only by us. Proceed?

On 2010/12/27 08:25:06, Dmitry Polukhin wrote:
> I would prefer passing this in constructor as argument in stead of using
setter.

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/username_view.h (right):

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/username_view.h:41: bool get_use_small_shape()
const { return use_small_shape_; }
On 2010/12/27 08:25:06, Dmitry Polukhin wrote:
> Getter shoudn't have get in its name. Comment about the functions would be
nice.

Done.

[Dmitry Polukhin, 2011-01-11 10:14:07]

LGTM

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/username_view.cc (right):

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/username_view.cc:36:
C::set_use_small_shape(use_small_shape);
On 2010/12/30 15:54:52, glotov wrote:
> I would prefer this too, but to do that I need to modify RoundedView<>
template
> class ctor. And it may be used not only by us. Proceed?
> 
> On 2010/12/27 08:25:06, Dmitry Polukhin wrote:
> > I would prefer passing this in constructor as argument in stead of using
> setter.
> 

I see the problem. Let's keep it as is. There is no point in making RoundedView
so specific to login.

[glotov, 2011-01-11 12:49:13]

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
File chrome/browser/chromeos/login/username_view.cc (right):

http://codereview.chromium.org/5966008/diff/1/chrome/browser/chromeos/login/u...
chrome/browser/chromeos/login/username_view.cc:36:
C::set_use_small_shape(use_small_shape);
Yes, I just added RoundedView<C>(val1, val2) : C(val1, val2) {} constructor to
do the trick, no changes in existing usage of RoundedView template.

[Dmitry Polukhin, 2011-01-11 13:36:36]

LGTM