Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_gtk.h

Issue 5966006: Hitting Tab should always move cursor to end of omnibox text. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Mac build. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h b/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
index 4508ffa7d41aa4c937a8a1c8fc9c956ad8fd3f03..27a3aaa13c4bcdbe019f99c1f41d40c912211777 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h
@@ -144,13 +144,12 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
virtual gfx::NativeView GetNativeView() const;
virtual CommandUpdater* GetCommandUpdater();
virtual void SetInstantSuggestion(const string16& suggestion);
+ virtual string16 GetInstantSuggestion() const;
virtual int TextWidth() const;
virtual bool IsImeComposing() const;
#if defined(TOOLKIT_VIEWS)
virtual views::View* AddToView(views::View* parent);
- virtual bool CommitInstantSuggestion(const string16& typed_text,
- const string16& suggested_text);
// Enables accessibility on AutocompleteEditView.
void EnableAccessibility();
@@ -183,8 +182,6 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
// the animation state.
void UpdateInstantViewColors();
- bool CommitInstantSuggestion();
-
GtkWidget* text_view() {
return text_view_;
}
@@ -302,7 +299,7 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
// Get the character indices of the current selection. This honors
// direction, cp_max is the insertion point, and cp_min is the bound.
- CharRange GetSelection();
+ CharRange GetSelection() const;
// Translate from character positions to iterators for the current buffer.
void ItersFromCharRange(const CharRange& range,
@@ -312,6 +309,12 @@ class AutocompleteEditViewGtk : public AutocompleteEditView,
// Return the number of characers in the current buffer.
int GetTextLength() const;
+ // Places the caret at the given position. This clears any selection.
+ void PlaceCaretAt(int pos);
+
+ // Returns true if the caret is at the end of the content.
+ bool IsCaretAtEnd() const;
+
// Try to parse the current text as a URL and colorize the components.
void EmphasizeURLComponents();

Powered by Google App Engine
This is Rietveld 408576698