Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_unittest.cc

Issue 5966006: Hitting Tab should always move cursor to end of omnibox text. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Mac build. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_edit_unittest.cc
diff --git a/chrome/browser/autocomplete/autocomplete_edit_unittest.cc b/chrome/browser/autocomplete/autocomplete_edit_unittest.cc
index 7643936c5600072f86d1d9d9f882d058a3611eac..9d54555212800782689306604952e766b9b0533b 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_unittest.cc
+++ b/chrome/browser/autocomplete/autocomplete_edit_unittest.cc
@@ -56,14 +56,12 @@ class TestingAutocompleteEditView : public AutocompleteEditView {
virtual gfx::NativeView GetNativeView() const { return 0; }
virtual CommandUpdater* GetCommandUpdater() { return NULL; }
virtual void SetInstantSuggestion(const string16& input) {}
+ virtual string16 GetInstantSuggestion() const { return string16(); }
virtual int TextWidth() const { return 0; }
virtual bool IsImeComposing() const { return false; }
#if defined(TOOLKIT_VIEWS)
virtual views::View* AddToView(views::View* parent) { return NULL; }
- virtual bool CommitInstantSuggestion(
- const string16& typed_text,
- const string16& suggested_text) { return false; }
#endif
private:
@@ -76,7 +74,7 @@ class TestingAutocompleteEditController : public AutocompleteEditController {
virtual void OnAutocompleteWillClosePopup() {}
virtual void OnAutocompleteLosingFocus(gfx::NativeView view_gaining_focus) {}
virtual void OnAutocompleteWillAccept() {}
- virtual bool OnCommitSuggestedText(const string16& typed_text) {
+ virtual bool OnCommitSuggestedText(bool skip_inline_autocomplete) {
return false;
}
virtual bool AcceptCurrentInstantPreview() {
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit.cc ('k') | chrome/browser/autocomplete/autocomplete_edit_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698