Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit.h

Issue 5966006: Hitting Tab should always move cursor to end of omnibox text. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Mac build. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit.h b/chrome/browser/autocomplete/autocomplete_edit.h
index 7b00fc6ca4d93e559ba18f9091d128299eb7289d..3b8c28779bdefe10beb5a129e47a4c3263b56d2f 100644
--- a/chrome/browser/autocomplete/autocomplete_edit.h
+++ b/chrome/browser/autocomplete/autocomplete_edit.h
@@ -48,9 +48,11 @@ class AutocompleteEditController {
// OnAutoCompleteAccept.
virtual void OnAutocompleteWillAccept() = 0;
- // Commits the suggested text. |typed_text| is the current text showing in the
- // autocomplete. Returns true if the text was committed.
- virtual bool OnCommitSuggestedText(const string16& typed_text) = 0;
+ // Commits the suggested text. If |skip_inline_autocomplete| is true then the
+ // suggested text will be committed as final text as if it's inputted by the
+ // user, rather than as inline autocomplete suggest.
+ // Returns true if the text was committed.
+ virtual bool OnCommitSuggestedText(bool skip_inline_autocomplete) = 0;
// Accepts the currently showing instant preview, if any, and returns true.
// Returns false if there is no instant preview showing.
@@ -191,8 +193,11 @@ class AutocompleteEditModel : public NotificationObserver {
void SetUserText(const string16& text);
// Calls through to SearchProvider::FinalizeInstantQuery.
+ // If |skip_inline_autocomplete| is true then the |suggest_text| will be
+ // turned into final text instead of inline autocomplete suggest.
void FinalizeInstantQuery(const string16& input_text,
- const string16& suggest_text);
+ const string16& suggest_text,
+ bool skip_inline_autocomplete);
// Reverts the edit model back to its unedited state (permanent text showing,
// no user input in progress).
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698