Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_mac.h

Issue 5966006: Hitting Tab should always move cursor to end of omnibox text. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix AutocompleteEditViewViews. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_mac.h b/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
index a6713939a02616be26c1098d37d8f7f2059a6ce7..964ff9c45df1e6d8e19df2568db0fa1bea9dec68 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_mac.h
@@ -84,6 +84,7 @@ class AutocompleteEditViewMac : public AutocompleteEditView,
virtual gfx::NativeView GetNativeView() const;
virtual CommandUpdater* GetCommandUpdater();
virtual void SetInstantSuggestion(const string16& input);
+ virtual string16 GetInstantSuggestion() const;
virtual int TextWidth() const;
virtual bool IsImeComposing() const;
@@ -104,8 +105,6 @@ class AutocompleteEditViewMac : public AutocompleteEditView,
virtual void OnSetFocus(bool control_down);
virtual void OnKillFocus();
- bool CommitSuggestText();
-
// Helper for LocationBarViewMac. Optionally selects all in |field_|.
void FocusLocation(bool select_all);
@@ -160,6 +159,9 @@ class AutocompleteEditViewMac : public AutocompleteEditView,
// Returns the non-suggest portion of |field_|'s string value.
NSString* GetNonSuggestTextSubstring() const;
+ // Returns the suggest portion of |field_|'s string value.
+ NSString* GetSuggestTextSubstring() const;
+
// Pass the current content of |field_| to SetText(), maintaining
// any selection. Named to be consistent with GTK and Windows,
// though here we cannot really do the in-place operation they do.

Powered by Google App Engine
This is Rietveld 408576698