Hitting Tab should always move cursor to end of omnibox text.

chrome/browser/ui/gtk/location_bar_view_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 440 matching lines @@
 
   InstantController* instant = browser_->instant();
   if (instant)
     instant->OnAutocompleteLostFocus(view_gaining_focus);
 }
 
 void LocationBarViewGtk::OnAutocompleteWillAccept() {
   update_instant_ = false;
 }
 
-bool LocationBarViewGtk::OnCommitSuggestedText(
-    const string16& typed_text) {
-  return browser_->instant() && location_entry_->CommitInstantSuggestion();
+bool LocationBarViewGtk::OnCommitSuggestedText(bool skip_inline_autocomplete) {
+  if (!browser_->instant())
+    return false;
+
+  const string16 suggestion = location_entry_->GetInstantSuggestion();
+  if (suggestion.empty())
+    return false;
+
+  location_entry_->model()->FinalizeInstantQuery(
+      location_entry_->GetText(), suggestion, skip_inline_autocomplete);
+  return true;
 }
 
 bool LocationBarViewGtk::AcceptCurrentInstantPreview() {
   return InstantController::CommitIfCurrent(browser_->instant());
 }
 
 void LocationBarViewGtk::OnPopupBoundsChanged(const gfx::Rect& bounds) {
   InstantController* instant = browser_->instant();
   if (instant)
     instant->SetOmniboxBounds(bounds);
@@ skipping 57 matching lines @@
   if (update_instant_ && instant && GetTabContents()) {
     if (location_entry_->model()->user_input_in_progress() &&
         location_entry_->model()->popup_model()->IsOpen()) {
       instant->Update(
           browser_->GetSelectedTabContentsWrapper(),
           location_entry_->model()->CurrentMatch(),
           location_entry_->GetText(),
           location_entry_->model()->UseVerbatimInstant(),
           &suggested_text);
       if (!instant->MightSupportInstant()) {
-        location_entry_->model()->FinalizeInstantQuery(string16(),
-                                                       string16());
+        location_entry_->model()->FinalizeInstantQuery(
+            string16(), string16(), false);
       }
     } else {
       instant->DestroyPreviewContents();
-      location_entry_->model()->FinalizeInstantQuery(string16(),
-                                                     string16());
+      location_entry_->model()->FinalizeInstantQuery(
+          string16(), string16(), false);
     }
   }
 
   SetSuggestedText(suggested_text);
 }
 
 void LocationBarViewGtk::OnSelectionBoundsChanged() {
   NOTIMPLEMENTED();
 }
 
@@ skipping 62 matching lines @@
 
 void LocationBarViewGtk::SetSuggestedText(const string16& text) {
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kInstantAutocompleteImmediately)) {
     // This method is internally invoked to reset suggest text, so we only do
     // anything if the text isn't empty.
     // TODO: if we keep autocomplete, make it so this isn't invoked with empty
     // text.
     if (!text.empty()) {
       location_entry_->model()->FinalizeInstantQuery(
-          location_entry_->GetText(), text);
+          location_entry_->GetText(), text, false);
     }
   } else {
     location_entry_->SetInstantSuggestion(text);
   }
 }
 
 std::wstring LocationBarViewGtk::GetInputString() const {
   return location_input_;
 }
 
@@ skipping 902 matching lines @@
 
   std::string badge_text = page_action_->GetBadgeText(tab_id);
   if (badge_text.empty())
     return FALSE;
 
   gfx::CanvasSkiaPaint canvas(event, false);
   gfx::Rect bounding_rect(widget->allocation);
   page_action_->PaintBadge(&canvas, bounding_rect, tab_id);
   return FALSE;
 }