Hitting Tab should always move cursor to end of omnibox text.

chrome/browser/autocomplete/autocomplete_edit_view_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdio.h>
 
 #include "base/message_loop.h"
 #include "base/string16.h"
 #include "base/string_util.h"
 #include "base/time.h"
@@ skipping 926 matching lines @@
     // New temporary text is shown.
     ASSERT_EQ(selected_text, edit_view->GetText());
 
     // As the current selected item is the new default item, pressing Escape key
     // should revert all directly.
     ASSERT_TRUE(edit_view->model()->OnEscapeKeyPressed());
     ASSERT_EQ(old_text, edit_view->GetText());
     ASSERT_TRUE(edit_view->IsSelectAll());
   }
 
+  void TabMoveCursorToEndTest() {
+    AutocompleteEditView* edit_view = NULL;
+    ASSERT_NO_FATAL_FAILURE(GetAutocompleteEditView(&edit_view));
+
+    edit_view->SetUserText(ASCIIToUTF16("Hello world"));
+
+    // Move cursor to the beginning.
+    ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_HOME, false, false, false));
+
+    string16::size_type start, end;
+    edit_view->GetSelectionBounds(&start, &end);
+    EXPECT_EQ(0U, start);
+    EXPECT_EQ(0U, end);
+
+    // Pressing tab should move cursor to the end.
+    ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_TAB, false, false, false));
+
+    edit_view->GetSelectionBounds(&start, &end);
+    EXPECT_EQ(edit_view->GetText().size(), start);
+    EXPECT_EQ(edit_view->GetText().size(), end);
+
+    // The location bar should still have focus.
+    ASSERT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_LOCATION_BAR));
+
+    // Select all text.
+    edit_view->SelectAll(true);
+    EXPECT_TRUE(edit_view->IsSelectAll());
+    edit_view->GetSelectionBounds(&start, &end);
+    EXPECT_EQ(0U, start);
+    EXPECT_EQ(edit_view->GetText().size(), end);
+
+    // Pressing tab should move cursor to the end.
+    ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_TAB, false, false, false));
+
+    edit_view->GetSelectionBounds(&start, &end);
+    EXPECT_EQ(edit_view->GetText().size(), start);
+    EXPECT_EQ(edit_view->GetText().size(), end);
+
+    // The location bar should still have focus.
+    ASSERT_TRUE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_LOCATION_BAR));
+
+    // Pressing tab when cursor is at the end should change focus.
+    ASSERT_NO_FATAL_FAILURE(SendKey(ui::VKEY_TAB, false, false, false));
+
+    ASSERT_FALSE(ui_test_utils::IsViewFocused(browser(), VIEW_ID_LOCATION_BAR));
+  }
 };
 
 // Test if ctrl-* accelerators are workable in omnibox.
 // See http://crbug.com/19193: omnibox blocks ctrl-* commands
 //
 // Flaky on interactive tests (dbg), http://crbug.com/69433
 IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, FLAKY_BrowserAccelerators) {
   BrowserAcceleratorsTest();
 }
 
@@ skipping 41 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, NonSubstitutingKeywordTest) {
   NonSubstitutingKeywordTest();
 }
 
 IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, DeleteItem) {
   DeleteItemTest();
 }
 
+IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, TabMoveCursorToEnd) {
+  TabMoveCursorToEndTest();
+}
+
 #if defined(OS_LINUX)
 // TODO(oshima): enable these tests for views-implmentation when
 // these featuers are supported.
 
 IN_PROC_BROWSER_TEST_F(AutocompleteEditViewTest, UndoRedoLinux) {
   ui_test_utils::NavigateToURL(browser(), GURL(chrome::kAboutBlankURL));
   browser()->FocusLocationBar();
 
   AutocompleteEditView* edit_view = NULL;
   ASSERT_NO_FATAL_FAILURE(GetAutocompleteEditView(&edit_view));
@@ skipping 165 matching lines @@
 
 IN_PROC_BROWSER_TEST_F(AutocompleteEditViewViewsTest,
                        NonSubstitutingKeywordTest) {
   NonSubstitutingKeywordTest();
 }
 
 IN_PROC_BROWSER_TEST_F(AutocompleteEditViewViewsTest, DeleteItem) {
   DeleteItemTest();
 }
 
+// TODO(suzhe): This test is broken because of broken ViewID support when
+// enabling AutocompleteEditViewViews.
+IN_PROC_BROWSER_TEST_F(AutocompleteEditViewViewsTest,
+                       DISABLED_TabMoveCursorToEnd) {
+  TabMoveCursorToEndTest();
+}
+
 #endif