Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/browser/autocomplete/autocomplete_edit_view_views.h

Issue 5966006: Hitting Tab should always move cursor to end of omnibox text. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix AutocompleteEditViewViews. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_VIEW_VIEWS_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_VIEW_VIEWS_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_VIEW_VIEWS_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_VIEW_VIEWS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 virtual void SetFocus(); 105 virtual void SetFocus();
106 virtual void OnTemporaryTextMaybeChanged(const string16& display_text, 106 virtual void OnTemporaryTextMaybeChanged(const string16& display_text,
107 bool save_original_selection); 107 bool save_original_selection);
108 virtual bool OnInlineAutocompleteTextMaybeChanged( 108 virtual bool OnInlineAutocompleteTextMaybeChanged(
109 const string16& display_text, size_t user_text_length); 109 const string16& display_text, size_t user_text_length);
110 virtual void OnRevertTemporaryText(); 110 virtual void OnRevertTemporaryText();
111 virtual void OnBeforePossibleChange(); 111 virtual void OnBeforePossibleChange();
112 virtual bool OnAfterPossibleChange(); 112 virtual bool OnAfterPossibleChange();
113 virtual gfx::NativeView GetNativeView() const; 113 virtual gfx::NativeView GetNativeView() const;
114 virtual CommandUpdater* GetCommandUpdater(); 114 virtual CommandUpdater* GetCommandUpdater();
115 virtual views::View* AddToView(views::View* parent); 115 virtual void SetInstantSuggestion(const string16& input);
116 virtual string16 GetInstantSuggestion() const;
116 virtual int TextWidth() const; 117 virtual int TextWidth() const;
117 virtual bool IsImeComposing() const; 118 virtual bool IsImeComposing() const;
118 virtual bool CommitInstantSuggestion(const string16& typed_text, 119 virtual views::View* AddToView(views::View* parent);
119 const string16& suggested_text);
120 virtual void SetInstantSuggestion(const string16& input);
121 120
122 // Overridden from NotificationObserver: 121 // Overridden from NotificationObserver:
123 virtual void Observe(NotificationType type, 122 virtual void Observe(NotificationType type,
124 const NotificationSource& source, 123 const NotificationSource& source,
125 const NotificationDetails& details); 124 const NotificationDetails& details);
126 125
127 // Overridden from Textfield::Controller 126 // Overridden from Textfield::Controller
128 virtual void ContentsChanged(views::Textfield* sender, 127 virtual void ContentsChanged(views::Textfield* sender,
129 const string16& new_contents); 128 const string16& new_contents);
130 virtual bool HandleKeyEvent(views::Textfield* sender, 129 virtual bool HandleKeyEvent(views::Textfield* sender,
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 // This flag should be set for changes directly caused by a key press event, 197 // This flag should be set for changes directly caused by a key press event,
199 // including changes to content text, selection range and preedit string. 198 // including changes to content text, selection range and preedit string.
200 // Changes caused by function calls like SetUserText() should not affect this 199 // Changes caused by function calls like SetUserText() should not affect this
201 // flag. 200 // flag.
202 bool content_maybe_changed_by_key_press_; 201 bool content_maybe_changed_by_key_press_;
203 202
204 DISALLOW_COPY_AND_ASSIGN(AutocompleteEditViewViews); 203 DISALLOW_COPY_AND_ASSIGN(AutocompleteEditViewViews);
205 }; 204 };
206 205
207 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_VIEW_VIEWS_H_ 206 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_VIEW_VIEWS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698