Hitting Tab should always move cursor to end of omnibox text.

chrome/browser/autocomplete/autocomplete_edit_view_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit_view_views.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 179 matching lines @@
   } else if (!handled && event.GetKeyCode() == ui::VKEY_UP) {
     model_->OnUpOrDownKeyPressed(-1);
     handled = true;
   } else if (!handled && event.GetKeyCode() == ui::VKEY_DOWN) {
     model_->OnUpOrDownKeyPressed(1);
     handled = true;
   } else if (!handled &&
              event.GetKeyCode() == ui::VKEY_TAB &&
              !event.IsShiftDown() &&
              !event.IsControlDown()) {
-    if (model_->is_keyword_hint() && !model_->keyword().empty()) {
-      model_->AcceptKeyword();
-      handled = true;
+    if (model_->is_keyword_hint()) {
+      handled = model_->AcceptKeyword();
     } else {
+      string16::size_type start = 0;
+      string16::size_type end = 0;
+      size_t length = GetTextLength();
+      GetSelectionBounds(&start, &end);
+      if (start != end || start < length) {
+        OnBeforePossibleChange();

[sky, 2011/01/27 19:55:31]

Same question about the need for OnBefore/after here.

+        SelectRange(length, length);
+        OnAfterPossibleChange();
+        handled = true;
+      }

[oshima, 2011/01/27 21:17:44]

instant is not working on views impl and i'd rather leave it unimplemented
rather than having something incomplete.

[James Su, 2011/01/27 21:55:53]

Above code is nothing to do with instant support. It only changes the behavior
of Tab key when the cursor is not at the line end.

+
       // TODO(Oshima): handle instant
     }
   }
   // TODO(oshima): page up & down
 
   return handled;
 }
 
 bool AutocompleteEditViewViews::HandleKeyReleaseEvent(
     const views::KeyEvent& event) {
@@ skipping 306 matching lines @@
 }
 
 gfx::NativeView AutocompleteEditViewViews::GetNativeView() const {
   return GetWidget()->GetNativeView();
 }
 
 CommandUpdater* AutocompleteEditViewViews::GetCommandUpdater() {
   return command_updater_;
 }
 
-views::View* AutocompleteEditViewViews::AddToView(views::View* parent) {
-  parent->AddChildView(this);
-  AddChildView(textfield_);
-  return this;
+void AutocompleteEditViewViews::SetInstantSuggestion(const string16& input) {
+  NOTIMPLEMENTED();
+}
+
+string16 AutocompleteEditViewViews::GetInstantSuggestion() const {
+  NOTIMPLEMENTED();
+  return string16();
 }
 
 int AutocompleteEditViewViews::TextWidth() const {
   // TODO(oshima): add horizontal margin.
   return textfield_->font().GetStringWidth(textfield_->text());
 }
 
 bool AutocompleteEditViewViews::IsImeComposing() const {
   return false;
 }
 
-bool AutocompleteEditViewViews::CommitInstantSuggestion(
-    const string16& typed_text,
-    const string16& suggested_text) {
-  model_->FinalizeInstantQuery(typed_text, suggested_text);
-  return true;
-}
-
-void AutocompleteEditViewViews::SetInstantSuggestion(const string16& input) {
-  NOTIMPLEMENTED();
+views::View* AutocompleteEditViewViews::AddToView(views::View* parent) {
+  parent->AddChildView(this);
+  AddChildView(textfield_);
+  return this;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AutocompleteEditViewViews, NotificationObserver implementation:
 
 void AutocompleteEditViewViews::Observe(NotificationType type,
                                       const NotificationSource& source,
                                       const NotificationDetails& details) {
   DCHECK(type == NotificationType::BROWSER_THEME_CHANGED);
   SetBaseColor();
@@ skipping 64 matching lines @@
 
 string16 AutocompleteEditViewViews::GetSelectedText() const {
   // TODO(oshima): Support instant, IME.
   return textfield_->GetSelectedText();
 }
 
 void AutocompleteEditViewViews::SelectRange(size_t caret, size_t end) {
   const views::TextRange range(caret, end);
   textfield_->SelectRange(range);
 }