Issue 5965014: ARM: support regexp literals in lithium-codegen-arm. Also, update...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5965014: ARM: support regexp literals in lithium-codegen-arm. Also, update... (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: support regexp literals in lithium-codegen-arm. Also, update comment on the AllocateInNewSpace macroassembler method. Committed: http://code.google.com/p/v8/source/detail?r=6192

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -7 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+50 lines, -1 line	1 comment	Download
	M	src/arm/macro-assembler-arm.h	View		1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

9 years, 11 months ago (2011-01-05 21:58:55 UTC) #2

LGTM

http://codereview.chromium.org/5965014/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/5965014/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:2232: // r0 = regexp literal clone.
Maybe mention that r2 and r4 - r6 are used as temporaries.

Expand Messages | Collapse Messages