chrome/browser/resources/options/chromeos_accounts_options.html - Issue 5965003: Show warning text in the user settings page for non-owner users.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/chromeos_accounts_options.html

Issue 5965003: Show warning text in the user settings page for non-owner users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/chromeos/dom_ui/accounts_options_handler.cc ('k') | chrome/browser/resources/options/chromeos_accounts_options.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div class="page hidden" id="accountsPage">	1 <div class="page hidden" id="accountsPage">

2 <h1 i18n-content="accountsPage"></h1>	2 <h1 i18n-content="accountsPage"></h1>

3 <section>	3 <section>

4 <div class="option">	4 <div class="option">

	5 <div id="ownerOnlyWarning" class="hidden">

	6 <span id="warningIcon"></span>
	arv (Not doing code reviews) 2010/12/21 18:57:26 Sorry I wasn't clear. I was suggesting putting the Sorry I wasn't clear. I was suggesting putting the background image on the div (ownerOnlyWarning). Changing from a img to a span only buys us the src indirection. By moving it to the div we also reduce the dependency on the DOM for layout of the warning
	7 <span i18n-content="owner_only"></span>

	8 <span i18n-content="owner_user_id"></span>

	9 </div>

5 <table class="option-control-table">	10 <table class="option-control-table">

6 <tr>	11 <tr>

7 <td class="option-name">	12 <td class="option-name">

8 <label class="checkbox">	13 <label class="checkbox">

9 <input id="allowBwsiCheck" pref="cros.accounts.allowBWSI"	14 <input id="allowBwsiCheck" pref="cros.accounts.allowBWSI"

10 type="checkbox">	15 type="checkbox">

11 <span i18n-content="allow_BWSI"></span>	16 <span i18n-content="allow_BWSI"></span>

12 </label>	17 </label>

13 </td>	18 </td>

14 </tr>	19 </tr>

(...skipping 27 matching lines...) Expand all Loading...
42 i18n-values="placeholder:username_edit_hint">	47 i18n-values="placeholder:username_edit_hint">

43 </span>	48 </span>

44 </label>	49 </label>

45 </td></tr>	50 </td></tr>

46 </table>	51 </table>

47 </td></tr>	52 </td></tr>

48 </table>	53 </table>

49 </div>	54 </div>

50 </section>	55 </section>

51 </div>	56 </div>

OLD	NEW