Issue 5964011: Fix a couple of errors with bad Vorbis headers, and go through the associated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5964011: Fix a couple of errors with bad Vorbis headers, and go through the associated... (Closed)

Created:
9 years, 12 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
jschuh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/ffmpeg/

Visibility:
Public.

Fix a couple of errors with bad Vorbis headers, and go through the associated ffmpeg patching dance. BUG=68815 TEST=See bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70200

Created: 9 years, 12 months ago

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -1 line)
M	README.chromium	View	2 chunks	+9 lines, -0 lines	0 comments
A	patches/to_upstream/21_vorbis_overflow.patch	View	1 chunk	+25 lines, -0 lines	0 comments
M	source/patched-ffmpeg-mt/libavcodec/vorbis_dec.c	View	2 chunks	+7 lines, -1 line	0 comments

Total messages: 2 (0 generated)

jschuh

9 years, 12 months ago (2010-12-27 20:47:11 UTC) #2

lgtm (assuming that the ffmpeg patch application stuff is all good)