Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: chrome/browser/ui/cocoa/clear_browsing_data_controller_unittest.mm

Issue 5964008: Add UI to the Clear Browsing Data dialog to remove Flash LSO data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: linux compile fix Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/scoped_nsobject.h" 7 #include "base/scoped_nsobject.h"
8 #include "chrome/browser/browsing_data_remover.h" 8 #include "chrome/browser/browsing_data_remover.h"
9 #include "chrome/browser/prefs/pref_service.h" 9 #include "chrome/browser/prefs/pref_service.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 12 matching lines...) Expand all
23 virtual void SetUp() { 23 virtual void SetUp() {
24 CocoaTest::SetUp(); 24 CocoaTest::SetUp();
25 // Set up some interesting prefs: 25 // Set up some interesting prefs:
26 PrefService* prefs = helper_.profile()->GetPrefs(); 26 PrefService* prefs = helper_.profile()->GetPrefs();
27 prefs->SetBoolean(prefs::kDeleteBrowsingHistory, true); 27 prefs->SetBoolean(prefs::kDeleteBrowsingHistory, true);
28 prefs->SetBoolean(prefs::kDeleteDownloadHistory, false); 28 prefs->SetBoolean(prefs::kDeleteDownloadHistory, false);
29 prefs->SetBoolean(prefs::kDeleteCache, true); 29 prefs->SetBoolean(prefs::kDeleteCache, true);
30 prefs->SetBoolean(prefs::kDeleteCookies, false); 30 prefs->SetBoolean(prefs::kDeleteCookies, false);
31 prefs->SetBoolean(prefs::kDeletePasswords, true); 31 prefs->SetBoolean(prefs::kDeletePasswords, true);
32 prefs->SetBoolean(prefs::kDeleteFormData, false); 32 prefs->SetBoolean(prefs::kDeleteFormData, false);
33 prefs->SetBoolean(prefs::kDeleteLSOData, true);
33 prefs->SetInteger(prefs::kDeleteTimePeriod, 34 prefs->SetInteger(prefs::kDeleteTimePeriod,
34 BrowsingDataRemover::FOUR_WEEKS); 35 BrowsingDataRemover::FOUR_WEEKS);
35 controller_ = 36 controller_ =
36 [ClearBrowsingDataController controllerForProfile:helper_.profile()]; 37 [ClearBrowsingDataController controllerForProfile:helper_.profile()];
37 } 38 }
38 39
39 virtual void TearDown() { 40 virtual void TearDown() {
41 MessageLoop::current()->RunAllPending();
42
40 [controller_ closeDialog]; 43 [controller_ closeDialog];
41 CocoaTest::TearDown(); 44 CocoaTest::TearDown();
42 } 45 }
43 46
44 BrowserTestHelper helper_; 47 BrowserTestHelper helper_;
45 ClearBrowsingDataController* controller_; 48 ClearBrowsingDataController* controller_;
46 }; 49 };
47 50
48 TEST_F(ClearBrowsingDataControllerTest, InitialState) { 51 TEST_F(ClearBrowsingDataControllerTest, InitialState) {
49 // Check properties match the prefs set above: 52 // Check properties match the prefs set above:
50 EXPECT_TRUE([controller_ clearBrowsingHistory]); 53 EXPECT_TRUE([controller_ clearBrowsingHistory]);
51 EXPECT_FALSE([controller_ clearDownloadHistory]); 54 EXPECT_FALSE([controller_ clearDownloadHistory]);
52 EXPECT_TRUE([controller_ emptyCache]); 55 EXPECT_TRUE([controller_ emptyCache]);
53 EXPECT_FALSE([controller_ deleteCookies]); 56 EXPECT_FALSE([controller_ deleteCookies]);
54 EXPECT_TRUE([controller_ clearSavedPasswords]); 57 EXPECT_TRUE([controller_ clearSavedPasswords]);
55 EXPECT_FALSE([controller_ clearFormData]); 58 EXPECT_FALSE([controller_ clearFormData]);
59 EXPECT_TRUE([controller_ clearLSOData]);
56 EXPECT_EQ(BrowsingDataRemover::FOUR_WEEKS, 60 EXPECT_EQ(BrowsingDataRemover::FOUR_WEEKS,
57 [controller_ timePeriod]); 61 [controller_ timePeriod]);
58 } 62 }
59 63
64 TEST_F(ClearBrowsingDataControllerTest, ClearLSOData) {
65 PrefService* prefs = helper_.profile()->GetPrefs();
66
67 // Disable clearing LSO data.
68 prefs->SetBoolean(prefs::kClearPluginLSODataEnabled, false);
69 EXPECT_TRUE([controller_ clearLSOData]);
70 EXPECT_FALSE([controller_ clearLSODataEnabled]);
71 EXPECT_FALSE([controller_ clearLSODataCheckbox]);
72
73 // Enabling it again should restore the old value of the checkbox.
74 prefs->SetBoolean(prefs::kClearPluginLSODataEnabled, true);
75 EXPECT_TRUE([controller_ clearLSODataEnabled]);
76 EXPECT_TRUE([controller_ clearLSODataCheckbox]);
77
78 // Unchecking the checkbox should set the preference to false.
79 [controller_ setClearLSODataCheckbox:NO];
80 [controller_ persistToPrefs];
81 EXPECT_FALSE(prefs->GetBoolean(prefs::kDeleteLSOData));
82 }
83
60 TEST_F(ClearBrowsingDataControllerTest, InitialRemoveMask) { 84 TEST_F(ClearBrowsingDataControllerTest, InitialRemoveMask) {
61 // Check that the remove-mask matches the initial properties: 85 // Check that the remove-mask matches the initial properties:
62 EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY | 86 EXPECT_EQ(BrowsingDataRemover::REMOVE_HISTORY |
63 BrowsingDataRemover::REMOVE_CACHE | 87 BrowsingDataRemover::REMOVE_CACHE |
64 BrowsingDataRemover::REMOVE_PASSWORDS, 88 BrowsingDataRemover::REMOVE_PASSWORDS |
89 BrowsingDataRemover::REMOVE_LSO_DATA,
65 [controller_ removeMask]); 90 [controller_ removeMask]);
66 } 91 }
67 92
68 TEST_F(ClearBrowsingDataControllerTest, ModifiedRemoveMask) { 93 TEST_F(ClearBrowsingDataControllerTest, ModifiedRemoveMask) {
69 // Invert all properties and check that the remove-mask is still correct: 94 // Invert all properties and check that the remove-mask is still correct:
70 [controller_ setClearBrowsingHistory:false]; 95 [controller_ setClearBrowsingHistory:false];
71 [controller_ setClearDownloadHistory:true]; 96 [controller_ setClearDownloadHistory:true];
72 [controller_ setEmptyCache:false]; 97 [controller_ setEmptyCache:false];
73 [controller_ setDeleteCookies:true]; 98 [controller_ setDeleteCookies:true];
74 [controller_ setClearSavedPasswords:false]; 99 [controller_ setClearSavedPasswords:false];
75 [controller_ setClearFormData:true]; 100 [controller_ setClearFormData:true];
101 [controller_ setClearLSOData:false];
76 102
77 EXPECT_EQ(BrowsingDataRemover::REMOVE_DOWNLOADS | 103 EXPECT_EQ(BrowsingDataRemover::REMOVE_DOWNLOADS |
78 BrowsingDataRemover::REMOVE_COOKIES | 104 BrowsingDataRemover::REMOVE_COOKIES |
79 BrowsingDataRemover::REMOVE_FORM_DATA, 105 BrowsingDataRemover::REMOVE_FORM_DATA,
80 [controller_ removeMask]); 106 [controller_ removeMask]);
81 } 107 }
82 108
83 TEST_F(ClearBrowsingDataControllerTest, EmptyRemoveMask) { 109 TEST_F(ClearBrowsingDataControllerTest, EmptyRemoveMask) {
84 // Clear all properties and check that the remove-mask is zero: 110 // Clear all properties and check that the remove-mask is zero:
85 [controller_ setClearBrowsingHistory:false]; 111 [controller_ setClearBrowsingHistory:false];
86 [controller_ setClearDownloadHistory:false]; 112 [controller_ setClearDownloadHistory:false];
87 [controller_ setEmptyCache:false]; 113 [controller_ setEmptyCache:false];
88 [controller_ setDeleteCookies:false]; 114 [controller_ setDeleteCookies:false];
89 [controller_ setClearSavedPasswords:false]; 115 [controller_ setClearSavedPasswords:false];
90 [controller_ setClearFormData:false]; 116 [controller_ setClearFormData:false];
117 [controller_ setClearLSOData:false];
91 118
92 EXPECT_EQ(0, 119 EXPECT_EQ(0, [controller_ removeMask]);
93 [controller_ removeMask]);
94 } 120 }
95 121
96 TEST_F(ClearBrowsingDataControllerTest, PersistToPrefs) { 122 TEST_F(ClearBrowsingDataControllerTest, PersistToPrefs) {
97 // Change some settings and store to prefs: 123 // Change some settings and store to prefs:
98 [controller_ setClearBrowsingHistory:false]; 124 [controller_ setClearBrowsingHistory:false];
99 [controller_ setClearDownloadHistory:true]; 125 [controller_ setClearDownloadHistory:true];
100 [controller_ persistToPrefs]; 126 [controller_ persistToPrefs];
101 127
102 // Test that the modified settings were stored to prefs: 128 // Test that the modified settings were stored to prefs:
103 PrefService* prefs = helper_.profile()->GetPrefs(); 129 PrefService* prefs = helper_.profile()->GetPrefs();
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 object:controller 166 object:controller
141 userInfo:expectedInfo]; 167 userInfo:expectedInfo];
142 168
143 // This calls |-closeDialog| and cleans the controller up. 169 // This calls |-closeDialog| and cleans the controller up.
144 [controller dataRemoverDidFinish]; 170 [controller dataRemoverDidFinish];
145 171
146 [observer verify]; 172 [observer verify];
147 } 173 }
148 174
149 } // namespace 175 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698