Add UI to the Clear Browsing Data dialog to remove Flash LSO data.

chrome/browser/resources/options/clear_browser_data_overlay.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
 
   /**
    * ClearBrowserData class
@@ skipping 24 matching lines @@
       // Setup option values for the time period select control.
       $('clearBrowsingDataTimePeriod').initializeValues(
           templateData.clearBrowsingDataTimeList);
 
       var f = this.updateCommitButtonState_.bind(this);
       var types = ['browser.clear_data.browsing_history',
                    'browser.clear_data.download_history',
                    'browser.clear_data.cache',
                    'browser.clear_data.cookies',
                    'browser.clear_data.passwords',
+                   'browser.clear_data.lso_data',
                    'browser.clear_data.form_data'];
       types.forEach(function(type) {
           Preferences.getInstance().addEventListener(type, f);
       });
 
       var checkboxes = document.querySelectorAll(
           '#checkboxListData input[type=checkbox]');
       for (var i = 0; i < checkboxes.length; i++) {
         checkboxes[i].onclick = f;
       }
       this.updateCommitButtonState_();
 
+      (function(self, pref) {

[Evan Stade, 2010/12/22 00:16:40]

why is this a single use function and not just a block of code

[Bernhard Bauer, 2010/12/22 03:40:05]

To restrict the scope of |self| and |pref| to this function, so we don't get
potential naming conflicts (and still can use short variable names).

If you think it hinders readability though, I'll inline it.

[Evan Stade, 2010/12/22 21:36:16]

yes please

[Bernhard Bauer, 2011/01/03 11:56:30]

Done.

+        // Listen to pref changes.
+        Preferences.getInstance().addEventListener(
+            pref,
+            function(event) {
+              var value = event.value && event.value['value'] != undefined ?
+                  event.value['value'] : event.value;

[Evan Stade, 2010/12/22 00:16:40]

as long as you're casting to boolean, can't you just do

event.value && event.value['value']

[Bernhard Bauer, 2010/12/22 03:40:05]

Probably. I have to admit, I copied that piece of code from Preferences.

[Bernhard Bauer, 2011/01/03 11:56:30]

Done.

+              self.pref_value = Boolean(value);
+              self.managed = event.value &&
+                             event.value['managed'] != undefined ?
+                  event.value['managed'] : false;
+              self.updateState();
+            });
+
+        ClearBrowserDataOverlay.setClearPluginLSODataEnabled =
+            function(enabled) {
+          self.manually_disabled = !enabled;
+          self.updateState();
+        };
+
+        // Listen to user events.
+        self.addEventListener('click',

[Evan Stade, 2010/12/22 00:16:40]

self.addEventListener('click', function (e) {
  [...]
});

[Bernhard Bauer, 2010/12/22 03:40:05]

Done.

+            function(e) {
+              Preferences.setBooleanPref(pref, self.checked, self.metric);
+            });
+
+        self.updateState = function() {
+          self.checked = self.pref_value && !self.manually_disabled;
+          self.disabled = self.managed || self.manually_disabled;
+          f();

[Evan Stade, 2010/12/22 00:16:40]

what

[Bernhard Bauer, 2010/12/22 03:40:05]

|f| is the updateCommitButtonState_ function bound to |this| (i.e. the
ClearBrowserDataOverlay). I copied it from above, but admittedly it should have
a longer name if it's being used so far from its declaration.

[Evan Stade, 2010/12/22 21:36:16]

oh, I see. Yes, it should have a better name.

[Bernhard Bauer, 2011/01/03 11:56:30]

Done.

+        };
+
+      })($('deleteLSODataCheckbox'), 'browser.clear_data.lso_data');
+
       // Setup click handler for the clear(Ok) button.
       $('clearBrowsingDataCommit').onclick = function(event) {
         chrome.send('performClearBrowserData');
       };
     },
 
     // Set the enabled state of the commit button.
     updateCommitButtonState_: function() {
       var checkboxes = document.querySelectorAll(
           '#checkboxListData input[type=checkbox]');
@@ skipping 11 matching lines @@
   //
   // Chrome callbacks
   //
   ClearBrowserDataOverlay.setClearingState = function(state) {
     $('deleteBrowsingHistoryCheckbox').disabled = state;
     $('deleteDownloadHistoryCheckbox').disabled = state;
     $('deleteCacheCheckbox').disabled = state;
     $('deleteCookiesCheckbox').disabled = state;
     $('deletePasswordsCheckbox').disabled = state;
     $('deleteFormDataCheckbox').disabled = state;
+    $('deleteLSODataCheckbox').disabled = state;
     $('clearBrowsingDataTimePeriod').disabled = state;
     $('clearBrowsingDataDismiss').disabled = state;
     $('cbdThrobber').style.visibility = state ? 'visible' : 'hidden';
 
     if (state)
       $('clearBrowsingDataCommit').disabled = true;
     else
       ClearBrowserDataOverlay.getInstance().updateCommitButtonState_();
 
     function advanceThrobber() {
@@ skipping 16 matching lines @@
     this.setClearingState(false);
   }
 
   // Export
   return {
     ClearBrowserDataOverlay: ClearBrowserDataOverlay
   };
 
 });