Last part of change for bug 49747....

Last part of change for bug 49747.

Implements the two-dimensional elider in app/text_elider.cc, and calls it from js_modal_dialog to reformat the message text prior to displaying an alert box.

The elider is implemented using the abstractions introduced in the previous CLs for bug 49747.

BUG=49746
TEST=TextEliderTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69981

[Tom Sepez, 2010-12-21 23:01:55]

Another review.

[Evan Martin, 2010-12-21 23:39:18]

Looks great.  LGTM, some suggestions below

http://codereview.chromium.org/5964007/diff/14002/app/text_elider.cc
File app/text_elider.cc (right):

http://codereview.chromium.org/5964007/diff/14002/app/text_elider.cc#newcode506
app/text_elider.cc:506: class RectangleString {
Can you add a comment describing this class?

http://codereview.chromium.org/5964007/diff/14002/app/text_elider.cc#newcode517
app/text_elider.cc:517: void AddString(const string16&  input);
typo: double space

http://codereview.chromium.org/5964007/diff/14002/app/text_elider.cc#newcode518
app/text_elider.cc:518: bool Finalize();
Please add comment docs to all functions and members in this class.

http://codereview.chromium.org/5964007/diff/14002/app/text_elider.cc#newcode546
app/text_elider.cc:546: output_->append(WideToUTF16(L"..."));
ASCIIToUTF16("...")

Elsewhere we use a Unicode ellipsis here.  I wonder if we should be consistent? 
I think the Unicode one looks terrible though, so I'm willing to overlook that
here... :)

http://codereview.chromium.org/5964007/diff/14002/app/text_elider.cc#newcode606
app/text_elider.cc:606: output_->append(WideToUTF16(L"\n"));
ASCIIToUTF16("\n")

http://codereview.chromium.org/5964007/diff/14002/app/text_elider.h
File app/text_elider.h (right):

http://codereview.chromium.org/5964007/diff/14002/app/text_elider.h#newcode108
app/text_elider.h:108: // lines that are  too long are broken into pieces, first
at naturally
typo: double space

http://codereview.chromium.org/5964007/diff/14002/app/text_elider_unittest.cc
File app/text_elider_unittest.cc (right):

http://codereview.chromium.org/5964007/diff/14002/app/text_elider_unittest.cc...
app/text_elider_unittest.cc:397: { L"Hi, my name is Tom",  1, 40, false, L"Hi,
my name is Tom" },
Awesome test suite!

[brettw, 2010-12-22 16:21:27]

I don't have anything else to add over what Evan said.