Issue 5964004: Use WINDOW instead of BUBBLE for the throbber widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5964004: Use WINDOW instead of BUBBLE for the throbber widget. (Closed)

Created:
10 years ago by altimofeev

Modified:
9 years, 7 months ago

Reviewers:
whywhat

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/chromeos/login

Visibility:
Public.

Description

Use WINDOW instead of BUBBLE for the throbber widget. This fix solves the problem with the throbber widget is always shown on the top of the windows. Also it uses parent GtkWindow instead of GtkWidget. BUG=chromium-os:9770 TEST=manaual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70192

Patch Set 1 #

Total comments: 2

Patch Set 2 : merged #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -16 lines)			Patch
	M	chrome/browser/chromeos/login/helper.cc	View	1	2 chunks	+32 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM http://codereview.chromium.org/5964004/diff/1/chrome/browser/chromeos/login/helper.cc File chrome/browser/chromeos/login/helper.cc (right): http://codereview.chromium.org/5964004/diff/1/chrome/browser/chromeos/login/helper.cc#newcode91 chrome/browser/chromeos/login/helper.cc:91: while (host_gtk_window && !GTK_IS_WINDOW(host_gtk_window)) { We don't generally ...

10 years ago (2010-12-20 19:24:18 UTC) #2

altimofeev

9 years, 12 months ago (2010-12-27 13:29:09 UTC) #3

http://codereview.chromium.org/5964004/diff/1/chrome/browser/chromeos/login/h...
File chrome/browser/chromeos/login/helper.cc (right):

http://codereview.chromium.org/5964004/diff/1/chrome/browser/chromeos/login/h...
chrome/browser/chromeos/login/helper.cc:91: while (host_gtk_window &&
!GTK_IS_WINDOW(host_gtk_window)) {
On 2010/12/20 19:24:18, whywhat wrote:
> We don't generally use {} for one line loop or condition bodies.

Done.

Expand Messages | Collapse Messages