Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: chrome/browser/autofill/autofill_manager.h

Issue 5963004: Add autofill metrics to dig into the failure case. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index c64627f9b0515c2f73cb615e8bfa7cf8e9af16e0..0b8804a6dedd84744e546f0f0940f8e194106b4b 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -86,6 +86,8 @@ class AutoFillManager : public IPC::Channel::Listener,
}
void set_metric_logger(const AutoFillMetrics* metric_logger);
+ ScopedVector<FormStructure>* form_structures() { return &form_structures_; }
+
// Maps GUIDs to and from IDs that are used to identify profiles and credit
// cards sent to and from the renderer process.
virtual int GUIDToID(const std::string& guid);
@@ -169,7 +171,8 @@ class AutoFillManager : public IPC::Channel::Listener,
// Uses existing personal data to determine possible field types for the
// |upload_form_structure_|.
- void DeterminePossibleFieldTypesForUpload();
+ void DeterminePossibleFieldTypesForUpload(
+ const FormStructure* cached_upload_form_structure);
// The TabContents hosting this AutoFillManager.
// Weak reference.
@@ -221,6 +224,7 @@ class AutoFillManager : public IPC::Channel::Listener,
FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, QualityMetrics);
FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest,
NoQualityMetricsForNonAutoFillableForms);
+ FRIEND_TEST_ALL_PREFIXES(AutoFillMetricsTest, QualityMetricsForFailure);
DISALLOW_COPY_AND_ASSIGN(AutoFillManager);
};
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698