Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issue 5963004: Add autofill metrics to dig into the failure case. (Closed)

Created:
10 years ago by Ilya Sherman
Modified:
9 years, 7 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, Paweł Hajdan Jr., James Hawkins, dhollowa, vadimb, Ilya Sherman
Visibility:
Public.

Description

Add autofill metrics to dig into the failure case. BUG=none TEST=unit_tests --gtest_filter=AutoFillMetricsTest.QualityMetricsForFailure Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71282

Patch Set 1 #

Patch Set 2 : Make the test more readable #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -17 lines) Patch
M chrome/browser/autofill/autofill_manager.h View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 2 6 chunks +41 lines, -14 lines 0 comments Download
M chrome/browser/autofill/autofill_metrics.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_metrics_unittest.cc View 1 2 4 chunks +146 lines, -1 line 0 comments Download
M chrome/browser/autofill/form_structure.h View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ilya Sherman
10 years ago (2010-12-23 11:50:16 UTC) #1
Ilya Sherman
I noticed while working on this patch that the test output is completely unreadable when ...
10 years ago (2010-12-23 23:28:44 UTC) #2
vadimb
Did you try flags from "Controlling How Much Information gMock Prints" section from GMockCookBook? On ...
10 years ago (2010-12-23 23:48:59 UTC) #3
Ilya Sherman
On 2010/12/23 23:48:59, vadimb wrote: > Did you try flags from "Controlling How Much Information ...
9 years, 11 months ago (2011-01-11 00:11:51 UTC) #4
dhollowa
9 years, 11 months ago (2011-01-11 01:21:38 UTC) #5
LGTM.  Though I notice some integration conflicts, looks like the trunk has
evolved since this was posted.

Powered by Google App Engine
This is Rietveld 408576698