Issue 5963003: Clean up is-ASCII checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5963003: Clean up is-ASCII checks. (Closed)

Created:
10 years ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Clean up is-ASCII checks. Committed: http://code.google.com/p/v8/source/detail?r=6109

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -38 lines)			Patch
M	src/heap.cc	View	2 chunks	+5 lines, -18 lines	1 comment	Download
M	src/heap-inl.h	View	1 chunk	+6 lines, -8 lines	0 comments	Download
M	src/ia32/regexp-macro-assembler-ia32.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	src/string-search.h	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years ago (2010-12-22 07:46:24 UTC) #2

LGTM

http://codereview.chromium.org/5963003/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/5963003/diff/1/src/heap.cc#newcode2555
src/heap.cc:2555: String::IsAscii(resource->data(), length);
Four-space indent?

Expand Messages | Collapse Messages