Issue 5962019: Revert "Major cleanup of cros_au_test_harness code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5962019: Revert "Major cleanup of cros_au_test_harness code." (Closed)

Created:
9 years, 11 months ago by jrbarnette

Modified:
9 years, 6 months ago

Reviewers:
adlr, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Revert "Major cleanup of cros_au_test_harness code." This reverts commit 2b2d7a1426f485bc2c6fb02399c52618db6dd0f2. The internal x86 buildbots have been reporting failures from cros_au_test_harness with every build, starting with the build that included the change being reverted. BUG=chromium-os:8901 TEST=None Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e7205e8

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -176 lines)			Patch
	M	bin/cros_au_test_harness.py	View		24 chunks	+165 lines, -176 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jrbarnette

Publishing this TBR sosa or adlr. The internal buildbots have been red for >24 hours; ...

9 years, 11 months ago (2011-01-06 02:37:10 UTC) #1

sosa

9 years, 11 months ago (2011-01-06 02:46:54 UTC) #2

post-TBR LGTM

On Wed, Jan 5, 2011 at 6:37 PM,  <jrbarnette@chromium.org> wrote:
> Reviewers: sosa, adlr,
>
> Message:
> Publishing this TBR sosa or adlr.  The internal buildbots have been red
> for >24 hours; one of the reasons is failures in cros_au_test_harness
> that started with the change being reverted.
>
>
> Description:
> Revert "Major cleanup of cros_au_test_harness code."
>
> This reverts commit 2b2d7a1426f485bc2c6fb02399c52618db6dd0f2.
>
> The internal x86 buildbots have been reporting failures from
> cros_au_test_harness with every build, starting with the build
> that included the change being reverted.
>
> BUG=None
> TEST=None
>
> Please review this at http://codereview.chromium.org/5962019/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
>
> Affected files:
>  M bin/cros_au_test_harness.py
>
>
>

Expand Messages | Collapse Messages